Skip to content

Commit a30da00

Browse files
authored
impl From<&AssetPath> for HandleId (#9132)
# Objective In [`AssetLoader::load()`](https://docs.rs/bevy/0.11.0/bevy/asset/trait.AssetLoader.html#tymethod.load), I have an [`AssetPath`](https://docs.rs/bevy/0.11.0/bevy/asset/struct.AssetPath.html) to a dependency asset. I get a handle to this dependency asset using [`LoadContext::get_handle()`](https://docs.rs/bevy/0.11.0/bevy/asset/struct.LoadContext.html#method.get_handle) passing the `AssetPath`. But I also need to pass this `AssetPath` to [`LoadedAsset::with_dependency()`](https://docs.rs/bevy/0.11.0/bevy/asset/struct.LoadedAsset.html#method.with_dependency) later. The current solution for this problem is either use `clone()`, but `AssetPath` may contains owned data. ```rust let dependency_path: AssetPath = _; let dependency = load_context.get_handle(dependency_path.clone()); // ... load_context.set_default_asset(LoadedAsset::new(my_asset).with_dependency(dependency_path)); ``` Or to use `AssetPathId::from(&path)` which is a bit verbose. ```rust let dependency_path: AssetPath = _; let dependency = load_context.get_handle(AssetPathId::from(&dependency_path)); // ... load_context.set_default_asset(LoadedAsset::new(my_asset).with_dependency(dependency_path)); ``` Ideal solution (introduced by this PR) is to pass a reference to `get_handle()`. ```rust let dependency_path: AssetPath = _; let dependency = load_context.get_handle(&dependency_path); // ... load_context.set_default_asset(LoadedAsset::new(my_asset).with_dependency(dependency_path)); ``` ## Solution Implement `From<&AssetPath>` for `HandleId` --- ## Changelog - Added: `HandleId` can be build from a reference to `AssetPath`.
1 parent 7154b59 commit a30da00

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

crates/bevy_asset/src/handle.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,12 @@ impl<'a> From<AssetPath<'a>> for HandleId {
4040
}
4141
}
4242

43+
impl<'a, 'b> From<&'a AssetPath<'b>> for HandleId {
44+
fn from(value: &'a AssetPath<'b>) -> Self {
45+
HandleId::AssetPathId(AssetPathId::from(value))
46+
}
47+
}
48+
4349
impl HandleId {
4450
/// Creates a random id for an asset of type `T`.
4551
#[inline]

0 commit comments

Comments
 (0)