Skip to content

Commit 08678a7

Browse files
committed
issue #199: Version 2.24.2 fails with Unresolved reference: jvmArgs
1 parent e51d2bf commit 08678a7

File tree

4 files changed

+12
-20
lines changed

4 files changed

+12
-20
lines changed

src/main/groovy/org/beryx/jlink/data/JPackageData.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,12 @@ class JPackageData {
107107

108108
@Input
109109
List<String> getJvmArgs() {
110-
this.@jvmArgs ?: launcherData.getJvmArgs(project)
110+
this.@jvmArgs ?: launcherData.getEffectiveJvmArgs(project)
111111
}
112112

113113
@Input
114114
List<String> getArgs() {
115-
this.@args ?: launcherData.getArgs(project)
115+
this.@args ?: launcherData.getEffectiveArgs(project)
116116
}
117117

118118
@OutputDirectory

src/main/groovy/org/beryx/jlink/data/LauncherData.groovy

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ import org.gradle.api.Project
2525
class LauncherData implements Serializable {
2626
private static final List<String> UNDEFINED_ARGS = ['<UNDEFINED>']
2727

28-
private List<String> configuredArgs = UNDEFINED_ARGS
29-
private List<String> configuredJvmArgs = UNDEFINED_ARGS
28+
List<String> args = UNDEFINED_ARGS
29+
List<String> jvmArgs = UNDEFINED_ARGS
3030

3131
String name
3232
File unixScriptTemplate
@@ -37,17 +37,11 @@ class LauncherData implements Serializable {
3737
this.name = name
3838
}
3939

40-
List<String> getArgs(Project project) {
41-
(configuredArgs != UNDEFINED_ARGS) ? configuredArgs : Util.getDefaultArgs(project)
42-
}
43-
void setArgs(List<String> args) {
44-
this.configuredArgs = args
40+
List<String> getEffectiveArgs(Project project) {
41+
(args != UNDEFINED_ARGS) ? args : Util.getDefaultArgs(project)
4542
}
4643

47-
List<String> getJvmArgs(Project project) {
48-
(configuredJvmArgs != UNDEFINED_ARGS) ? configuredJvmArgs : Util.getDefaultJvmArgs(project)
49-
}
50-
void setJvmArgs(List<String> jvmArgs) {
51-
this.configuredJvmArgs = jvmArgs
44+
List<String> getEffectiveJvmArgs(Project project) {
45+
(jvmArgs != UNDEFINED_ARGS) ? jvmArgs : Util.getDefaultJvmArgs(project)
5246
}
5347
}

src/main/groovy/org/beryx/jlink/impl/JPackageImageTaskImpl.groovy

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ package org.beryx.jlink.impl
1717

1818
import groovy.transform.CompileDynamic
1919
import groovy.transform.CompileStatic
20-
import org.beryx.jlink.data.JPackageData
2120
import org.beryx.jlink.data.JPackageTaskData
2221
import org.beryx.jlink.util.Util
2322
import org.gradle.api.GradleException
@@ -75,12 +74,12 @@ class JPackageImageTaskImpl extends BaseTaskImpl<JPackageTaskData> {
7574
stream << "main-class=$launcher.mainClass\n"
7675
}
7776

78-
def args = launcher.getArgs(project)
77+
def args = launcher.getEffectiveArgs(project)
7978
if(args) {
8079
stream << "arguments=${args.collect{adjustArg(it)}.join('\\n')}\n"
8180
}
8281

83-
def jvmArgs = launcher.getJvmArgs(project)
82+
def jvmArgs = launcher.getEffectiveJvmArgs(project)
8483
if(jvmArgs) {
8584
stream << "java-options=${jvmArgs.collect{adjustArg(it)}.join('\\n')}\n"
8685
}

src/main/groovy/org/beryx/jlink/util/LaunchScriptGenerator.groovy

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import org.gradle.api.Project
2525

2626
import java.util.function.Function
2727
import java.util.stream.Collectors
28-
import java.util.stream.Stream
2928

3029
@CompileStatic
3130
@TupleConstructor
@@ -88,11 +87,11 @@ class LaunchScriptGenerator {
8887
String getScript(Type type) {
8988
def engine = new SimpleTemplateEngine()
9089

91-
def args = launcherData.getArgs(project).stream()
90+
def args = launcherData.getEffectiveArgs(project).stream()
9291
.map{adjustArg(it, type) as CharSequence}
9392
.collect(Collectors.joining(' '))
9493

95-
def jvmArgs = launcherData.getJvmArgs(project).stream()
94+
def jvmArgs = launcherData.getEffectiveJvmArgs(project).stream()
9695
.map{adjustArg(it, type) as CharSequence}
9796
.collect(Collectors.joining(' '))
9897

0 commit comments

Comments
 (0)