Distortion effect implementation

[starakaj]

Hey! I've been having a lot of fun with the upshot package, just one thing I noticed looking at (and listening to) the distortion effect.

I'm not sure about this implementation? Clipping before you go into a tanh~ basically makes the tanh~ totally irrelevant, and probably isn't intended. The resulting sound is super crunchy and distorted, but if you were going for an overdrive effect then this isn't really correct.

[benjaminvanesser]

Dear Sam, Thanks for pointing that out. tanh~ is already taking the edge off a little bit before sending it to *~ 0.1. I could have multiplied by 0.075 instead to get the same result. I’m quite sure you would find more stuff that is not correct ;-). As long as you keep having a lot of fun with it...

…

-- ***@***.*** ***@***.***> | +32 497 190 626 | www.benjaminvanesser.be <http://www.benjaminvanesser.be/>

On 31 Mar 2024, at 22:10, Sam Tarakajian ***@***.***> wrote: Hey! I've been having a lot of fun with the upshot package, just one thing I noticed looking at (and listening to) the distortion effect. Screenshot.2024-03-31.at.4.07.46.PM.png (view on web) <https://github.com/benjaminvanesser/upshot/assets/523270/b355d2ec-3f05-4309-a13c-72c1e0a1941f> I'm not sure about this implementation? Clipping before you go into a tanh~ basically makes the tanh~ totally irrelevant, and probably isn't intended. The resulting sound is super crunchy and distorted, but if you were going for an overdrive effect then this isn't really correct. — Reply to this email directly, view it on GitHub <#2>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD5MOQ5QQWRONC5NHNXEQP3Y3BUSNAVCNFSM6AAAAABFQVO3FSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTOMJWGUYDQOI>. You are receiving this because you are subscribed to this thread.