Extensive permissions

[tomaszg7]

Hi!

Since new version, the addon requires permission to: "Have full, unrestricted access to Thunderbird, and your computer". I suppose it is caused by some changes in Thunderbird. However from user's perspective it is rather frightening (even though the later part of the sentence is not really true in any reasonable OS). It would be nice be able to use this addon without selling the soul ;)

[beltrachi]

Hi,

I can't fix this. I need Thunderbird API to allow me to do several operations that are not allowed yet. I'm using Experimental API till then, that's why it says I have full access to Thunderbird.

Current extensions API is documented here: https://thunderbird-webextensions.readthedocs.io/

I keep an eye on it from time to time so maybe in future versions the extension stops requiring unrestricted access, but right now its not possible.

[jobisoft]

Recent addition to the APIs are:

• onActiveDictionariesChanged
• getActiveDictionaries
• setActiveDictionaries

What is still missing to move away from Experiments is an onRecipientsChange event, which I promise to add during the 114 cycle.

You may have observed by the names of the new dictionary functions/events, that Thunderbird now supports multiple enabled dictionaries, which causes your add-on to fail in Thunderbird 102. I tried to replace your custom onLanguageChange event by the new onActiveDictionariesChanged event, but I was not able to see where context.language is set.

Your event does not seem to return the newly selected language, or you do not use it. The new event returns a JSON object with the names of all installed dictionaries as keys, and a boolean value to indicate if it is enabled or not.

I would like to offer help in updating your add-on for 102, if you run into an issue. But I would need a little help regarding context.language, to be able to get started.

John (MZLA Thunderbird Add-on coordinator)

[beltrachi]

Hi John,

that's great news! Thank you for your work, and for checking addon's code, I hope it has not been too hard to understand 😅

You may have observed by the names of the new dictionary functions/events, that Thunderbird now supports multiple enabled dictionaries, which make this add-on fail in Thunderird 102. I tried to replace your custom onLanguageChange event by the new onActiveDictionariesChanged event, but I was not able to see where context.language is set.

In language deducer there's contextBuilder method which gets the language from the compose window.
https://github.com/beltrachi/automatic_dictionary/blob/master/addon/ad/language_deducer.js#L50

Your event does not seem to return the the newly selected language or you do not use it. The new event returns a JSON object with the names of all installed dictionaries as keys and a boolean value to indicate if it is enabled or not.

... wow... that change might be tricky. All plugin logic is based on the idea that for a given group of recipients, there is a single preferred language... Would it make sense to just change the data structure from recipients => lang to recipients => [lang1, lang2] ?

For the heuristic part it might get tricky... it might need some thought.

I would like to offer help in updating your add-on for 102, if you run into an issue. But I would need a little help regarding context.language, to be able to get started.

Sure, please feel free to ask anything via email. I can try to create a PR with a POC, if you want too.

[beltrachi]

@jobisoft another question I had around was, is there any plan to have this feature in the core of TB?

[jobisoft]

@jobisoft another question I had around was, is there any plan to have this feature in the core of TB?

I do not know of any plans to add such a functionality to core.

[jobisoft]

I tried to move forward in
#136