-
-
Notifications
You must be signed in to change notification settings - Fork 133
Description
Setting editor.formatOnSaveMode to either "modifications" or "modificationsIfAvailable" in .vscode/settings.json still causes CSharpier to format the entire file on save.
After filling in the Environments information below, I realize that the CSharpier version installed by the VSCode extension seems to be quite old. According to #659 (comment) and #1376, this feature was added in 0.30.2, maybe the version shipped with the VSCode extension should be updated? Given how this affects an Editor feature.
Environments
- IDE Version: 1.104.0 (user setup)
- Extension Version: 2.0.8
- CSharpier Version:
%LOCALAPPDATA%\CSharpier\0.21.0(installed by the extension)
will NOT be the same as the extension version - Operating System: Version 10.0.26100 Numéro 26100
- .csharpierrc Settings: N/A
- .editorconfig Settings: .editorconfig.txt
Log Output
Steps to reproduce
In VSCode settings (I did it in my workspace's .vscode/settings.json)
{
"editor.formatOnSaveMode": "modifications",
}namespace TestNameSpace
{
}Save without formatting. Stage, commit.
Save. See the file change to
namespace TestNameSpace { }Expected behavior
No file change (should only format modifications)
Actual behavior
Entire file is formatted.