Make sure we can clear marked_unread with the beeper_inbox_state endpoint

Author: bradtgmurray

synapse/rest/client/account_data.py

@@ -189,13 +189,13 @@ async def on_PUT(
 
         body = parse_json_object_from_request(request)
 
-        if body.get("marked_unread"):
+        if "marked_unread" in body:
             marked_unread = {"unread": body["marked_unread"], "ts": ts}
             await self.handler.add_account_data_to_room(
                 user_id, room_id, "m.marked_unread", marked_unread
             )
 
-        if body.get("done"):
+        if "done" in body:
             done = {"updated_ts": ts, "at_ts": ts + body["done"].get("at_delta", 0)}
             await self.handler.add_account_data_to_room(
                 user_id, room_id, "com.beeper.inbox.done", done

tests/rest/client/test_account_data.py

@@ -132,3 +132,40 @@ def test_beeper_inbox_state_endpoint(self) -> None:
         )
         self.assertEqual(marked_unread["unread"], True)
         self.assertEqual(marked_unread["ts"], ts)
+
+    def test_beeper_inbox_state_endpoint_can_clear_unread(self) -> None:
+        store = self.hs.get_datastores().main
+
+        user_id = self.register_user("user", "password")
+        tok = self.login("user", "password")
+
+        room_id = self.helper.create_room_as(user_id, tok=tok)
+        channel = self.make_request(
+            "PUT",
+            f"/user/{user_id}/rooms/{room_id}/beeper_inbox_state",
+            {"marked_unread": False},
+            access_token=tok,
+        )
+
+        self.assertEqual(channel.code, 200, channel.result)
+
+        # FIXME: I give up, I don't know how to mock time in tests
+        # ts = self.clock.time_msec()
+        ts = 400
+
+        self.assertEqual(channel.code, 200, channel.result)
+        self.assertIsNone(
+            self.get_success(
+                store.get_account_data_for_room_and_type(
+                    user_id, room_id, "com.beeper.inbox.done"
+                )
+            )
+        )
+
+        marked_unread = self.get_success(
+            store.get_account_data_for_room_and_type(
+                user_id, room_id, "m.marked_unread"
+            )
+        )
+        self.assertEqual(marked_unread["unread"], False)
+        self.assertEqual(marked_unread["ts"], ts)