From 530f083fe81074305a10cbb51ee49c280f054299 Mon Sep 17 00:00:00 2001 From: Dhruva Rayasam Date: Mon, 30 Jun 2025 20:57:15 -0400 Subject: [PATCH 1/6] added changes to pom.xml and added github workflow --- .github/workflows/checkstyle.yml | 16 ++++++++++++++++ pom.xml | 20 ++++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 .github/workflows/checkstyle.yml diff --git a/.github/workflows/checkstyle.yml b/.github/workflows/checkstyle.yml new file mode 100644 index 0000000..25a191d --- /dev/null +++ b/.github/workflows/checkstyle.yml @@ -0,0 +1,16 @@ +name: Checkstyle + +on: [push, pull_request] + +jobs: + checkstyle: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - name: Set up JDK + uses: actions/setup-java@v4 + with: + distribution: 'temurin' + java-version: '21' + - name: Run Checkstyle + run: mvn checkstyle:check \ No newline at end of file diff --git a/pom.xml b/pom.xml index 216dda9..90fa171 100644 --- a/pom.xml +++ b/pom.xml @@ -36,6 +36,26 @@ + + org.apache.maven.plugins + maven-checkstyle-plugin + 3.3.0 + + google_checks.xml + UTF-8 + true + true + + + + checkstyle + verify + + check + + + + org.apache.maven.plugins maven-compiler-plugin From 04ec4b03e46eaad6c183186bc6bdac6f5dd3114d Mon Sep 17 00:00:00 2001 From: Dhruva Rayasam Date: Mon, 30 Jun 2025 21:01:50 -0400 Subject: [PATCH 2/6] added google_checks xml file --- google_checks.xml | 199 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 199 insertions(+) create mode 100644 google_checks.xml diff --git a/google_checks.xml b/google_checks.xml new file mode 100644 index 0000000..70d6bb3 --- /dev/null +++ b/google_checks.xml @@ -0,0 +1,199 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file From 5dcb67b1ece1961ba0b31e321eb11d0c9652b7fa Mon Sep 17 00:00:00 2001 From: Dhruva Rayasam Date: Mon, 30 Jun 2025 21:08:59 -0400 Subject: [PATCH 3/6] modified checkstyle, tested checkstyle locally --- google_checks.xml | 597 ++++++++++++++++++++++++++++++++-------------- 1 file changed, 423 insertions(+), 174 deletions(-) diff --git a/google_checks.xml b/google_checks.xml index 70d6bb3..ca5b165 100644 --- a/google_checks.xml +++ b/google_checks.xml @@ -1,199 +1,448 @@ + "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" + "https://checkstyle.org/dtds/configuration_1_3.dtd"> - - + + + + + + + + + + + + + + + + + + + + + + + + + + + - + + + + + - - - - - - + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - + + + - - - - + + + - - - - + + + - - - - - - + + + + + + + + + + + - - - - + + + + + + + - - - - + + + + + + + + + + + - - - - + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file From 68423c5b60e263389142b663b16cabdaec4349ee Mon Sep 17 00:00:00 2001 From: Dhruva Rayasam Date: Mon, 30 Jun 2025 21:40:35 -0400 Subject: [PATCH 4/6] checkstyle works locally, testing on github actions with new dependency --- pom.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pom.xml b/pom.xml index 90fa171..36808f5 100644 --- a/pom.xml +++ b/pom.xml @@ -32,6 +32,11 @@ tornado-runtime 1.1.1-dev + + com.google.guava + guava + 31.1-jre + From ab9c517ba7ffecf740cf158cb6f303a3c26c72de Mon Sep 17 00:00:00 2001 From: Dhruva Rayasam Date: Mon, 30 Jun 2025 22:21:43 -0400 Subject: [PATCH 5/6] updated pom and google checks to be compatible with latest maven version of checkstyle (lots of checkstyle errors currently) --- google_checks.xml | 438 +++------------------------------------------- pom.xml | 2 +- 2 files changed, 28 insertions(+), 412 deletions(-) diff --git a/google_checks.xml b/google_checks.xml index ca5b165..611fa0a 100644 --- a/google_checks.xml +++ b/google_checks.xml @@ -1,448 +1,64 @@ - - + "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" + "https://checkstyle.org/dtds/configuration_1_3.dtd"> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - - - - - - - - - - - - + - + - - - - + value="LITERAL_TRY, LITERAL_CATCH, LITERAL_IF, LITERAL_ELSE, LITERAL_DO"/> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, + STATIC_INIT, INSTANCE_INIT, ANNOTATION_DEF, ENUM_DEF, INTERFACE_DEF, + RECORD_DEF, COMPACT_CTOR_DEF, LITERAL_FINALLY, LITERAL_CATCH"/> + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + - - - - - - - - - - - - + - - - - + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + - - - - - - - - - - - - - - - - - - - - - - - - + - \ No newline at end of file + diff --git a/pom.xml b/pom.xml index 36808f5..e6c66ef 100644 --- a/pom.xml +++ b/pom.xml @@ -44,7 +44,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - 3.3.0 + 3.6.0 google_checks.xml UTF-8 From 4bc841a6ae20cdd19603c5a30aad3b8fdc519071 Mon Sep 17 00:00:00 2001 From: Dhruva Rayasam Date: Mon, 30 Jun 2025 22:31:04 -0400 Subject: [PATCH 6/6] changed pom so build doesn't fail on style check fail --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index e6c66ef..36e8863 100644 --- a/pom.xml +++ b/pom.xml @@ -49,7 +49,7 @@ google_checks.xml UTF-8 true - true + false