Skip to content

Commit 069fd24

Browse files
committed
BugFix: Chapter title added and activity filter issue fixed.
- CD-428
1 parent 495d8b7 commit 069fd24

15 files changed

+49
-18
lines changed

amd/build/learningtoolsinfo.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lang/en/local_learningtools.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@
8989
$string['sortbycourse'] = "Sort by course";
9090
$string['viewcourse'] = "View course";
9191
$string['viewactivity'] = "View Activity";
92+
$string['viewchapter'] = "View Chapter";
9293
$string['deletemessage'] = 'Delete Message';
9394
$string['deletemsgcheckfull'] = 'Are you absolutely sure you want to completely delete the bookmarks, including their bookmarks and other bookmarks data?';
9495
$string['deletednotmessage'] = 'Could not delete bookmarks!';
@@ -244,6 +245,7 @@
244245
$string['strftimemonthdateyear'] = '%B, %dth %Y';
245246
$string['strftimeyearmonth'] = '%Y/%m/%d';
246247
$string['strftimemonthnamedate'] = '%B %d, %Y';
248+
$string['subplugintype_ltool'] = "Learning Tool";
247249
$string['subplugintype_ltool_plural'] = 'Learning Tools';
248250
$string['strbookmarked'] = "<i class='fa fa-bookmark'></i> Bookmarked";
249251
$string['strbookmark'] = "<i class='fa fa-bookmark'></i> Bookmark";

lib.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -499,10 +499,8 @@ function local_learningtools_get_instance_tool_view_url($row) {
499499
$viewurl = $OUTPUT->single_button($courseurl, get_string('viewcourse', 'local_learningtools'), 'get');
500500
} else if ($data->instance == 'mod') {
501501
$pageurl = $row->pageurl;
502-
if ($row->itemtype == 'chapter') {
503-
$pageurl = $row->pageurl . "#chapters-list-" . $row->itemid;
504-
}
505-
$viewurl = $OUTPUT->single_button($pageurl, get_string('viewactivity', 'local_learningtools'), 'get');
502+
$buttonstr = ($row->itemtype == 'chapter') ? 'viewchapter' : 'viewactivity';
503+
$viewurl = $OUTPUT->single_button($pageurl, get_string($buttonstr, 'local_learningtools'), 'get');
506504
} else {
507505
$viewurl = $OUTPUT->single_button($row->pageurl, get_string('viewpage', 'local_learningtools'), 'get');
508506
}

0 commit comments

Comments
 (0)