Empty values cause errors and notifications are not sent

[joelsdc]

Hi,

After updating to rundeck to v3.0.8 I've noticed we are not receiving slack notifications any more.

I found this error in the logs:

2018-10-30 12:02:37.088 ERROR --- [pool-1-thread-1] rundeck.services.NotificationService     : Error sending notificat
ion: Notification{eventTrigger='onfailure', type='SlackNotification', content='{"additionalText":"","channel":"","title":"${job.Status} [${job.project}] ${job.fullName} run by ${job.username} (#${job.execid})","color":"","optionFields":
"","_includeFailedNodes":""}'}: class java.lang.NullPointerException: Cannot invoke method replaceAll() on null object

I added a quick condition to check for null, and then came up with this error:

2018-10-30 16:35:12.448 ERROR --- [eduler_Worker-1] rundeck.services.NotificationService     : Error sending notificat
ion: Notification{eventTrigger='onsuccess', type='SlackNotification', content='{"channel":"","optionFields":"","additionalText":"","color":"","title":"${job.Status} [${job.project}] ${job.fullName} run by ${job.username} (#${job.execid}
)","_includeFailedNodes":""}'}: class java.lang.NullPointerException: Cannot invoke method tokenize() on null object

Added another condition and I have slack notifications again.

I have no idea of groovy or how the plugin works, I just applied basic logic, so my workaround can be completely wrong.

Let me know what you think!

Thanks!!

[ReifiedException]

Unfortunately, this does not work with Rundeck 2.6.9-1 (I know it's seriously outdated, but it is still in use). Well, it fixes the situation in a certain way, but it seems the system-wide variables are not passed from Rundeck to Groovy script:
Started ${job.project} Job run by ${job.username} (#${job.execid})
Java based plugin works ok.