Skip to content

Commit 1bbb222

Browse files
committed
Use ImportsFiles consistently.
1 parent d0419ba commit 1bbb222

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

llvm/lib/LTO/LTO.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1419,10 +1419,10 @@ Error ThinBackendProc::emitFiles(
14191419
&DeclarationSummaries);
14201420

14211421
if (ShouldEmitImportsFiles) {
1422-
Error ImportFilesError = EmitImportsFiles(
1422+
Error ImportsFilesError = EmitImportsFiles(
14231423
ModulePath, NewModulePath + ".imports", ModuleToSummariesForIndex);
1424-
if (ImportFilesError)
1425-
return ImportFilesError;
1424+
if (ImportsFilesError)
1425+
return ImportsFilesError;
14261426
}
14271427

14281428
// Optionally, store the imports files.
@@ -2215,7 +2215,7 @@ class OutOfProcessThinBackend : public CGThinBackend {
22152215
StringRef ModuleID;
22162216
StringRef NativeObjectPath;
22172217
StringRef SummaryIndexPath;
2218-
ImportsFilesContainer ImportFiles;
2218+
ImportsFilesContainer ImportsFiles;
22192219
};
22202220
// The set of backend compilations jobs.
22212221
SmallVector<Job> Jobs;
@@ -2278,7 +2278,7 @@ class OutOfProcessThinBackend : public CGThinBackend {
22782278
BackendThreadPool.async(
22792279
[=](Job &J, const FunctionImporter::ImportMapTy &ImportList) {
22802280
if (auto E = emitFiles(ImportList, J.ModuleID, J.SummaryIndexPath,
2281-
J.ModuleID.str(), J.ImportFiles)) {
2281+
J.ModuleID.str(), J.ImportsFiles)) {
22822282
std::unique_lock<std::mutex> L(ErrMu);
22832283
if (Err)
22842284
Err = joinErrors(std::move(*Err), std::move(E));
@@ -2397,7 +2397,7 @@ class OutOfProcessThinBackend : public CGThinBackend {
23972397
// Add the bitcode files from which imports will be made. These do
23982398
// not explicitly appear on the backend compilation command lines
23992399
// but are recorded in the summary index shards.
2400-
llvm::append_range(Inputs, J.ImportFiles);
2400+
llvm::append_range(Inputs, J.ImportsFiles);
24012401
JOS.attribute("inputs", Array(Inputs));
24022402

24032403
JOS.attribute("outputs", Array(Outputs));

llvm/lib/LTO/ThinLTOCodeGenerator.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -828,7 +828,7 @@ void ThinLTOCodeGenerator::emitImports(Module &TheModule, StringRef OutputName,
828828

829829
// 'EmitImportsFiles' emits the list of modules from which to import from, and
830830
// the set of keys in `ModuleToSummariesForIndex` should be a superset of keys
831-
// in `DecSummaries`, so no need to use `DecSummaries` in `EmitImportFiles`.
831+
// in `DecSummaries`, so no need to use `DecSummaries` in `EmitImportsFiles`.
832832
GVSummaryPtrSet DecSummaries;
833833
ModuleToSummariesForIndexTy ModuleToSummariesForIndex;
834834
llvm::gatherImportedSummariesForModule(

llvm/test/ThinLTO/X86/dtlto/imports.ll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,16 @@ ERR: failed: DTLTO backend compilation: cannot open native object file:
4040
; Check that imports files are not created even if -save-temps is active.
4141
RUN: not %{command} -save-temps 2>&1 \
4242
RUN: | FileCheck %s --check-prefixes=ERR
43-
RUN: ls | FileCheck %s --check-prefix=NOIMPORTFILES
44-
NOIMPORTFILES-NOT: imports
43+
RUN: ls | FileCheck %s --check-prefix=NOIMPORTSFILES
44+
NOIMPORTSFILES-NOT: imports
4545

4646

4747
; Check that imports files are created with -thinlto-emit-imports.
4848
RUN: not %{command} -thinlto-emit-imports 2>&1 \
4949
RUN: | FileCheck %s --check-prefixes=ERR
50-
RUN: ls | FileCheck %s --check-prefix=IMPORTFILES
51-
IMPORTFILES: 0.bc.imports
52-
IMPORTFILES: 1.bc.imports
50+
RUN: ls | FileCheck %s --check-prefix=IMPORTSFILES
51+
IMPORTSFILES: 0.bc.imports
52+
IMPORTSFILES: 1.bc.imports
5353

5454
;--- 0.ll
5555
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"

0 commit comments

Comments
 (0)