fix #15

Author: bckohan

django_routines/management/commands/routine.py

@@ -220,18 +220,21 @@ def _subprocess(self, command: RCommand):
                     "_actions",
                     [],
                 )
+                expected_opts = len(command.options)
                 for opt, value in command.options.items():
                     for action in actions:
                         opt_strs = getattr(action, "option_strings", [])
                         if opt == getattr(action, "dest", None) and opt_strs:
                             if isinstance(value, bool):
-                                if value:
+                                if value is not getattr(action, "default", None):
                                     options.append(opt_strs[-1])
+                                else:
+                                    expected_opts -= 1
                             else:
                                 options.append(f"--{opt}={str(value)}")
                             break
 
-                if len(options) != len(command.options):
+                if len(options) != expected_opts:
                     raise CommandError(
                         _(
                             "Failed to convert {command} options to CLI format: {unconverted}"
@@ -259,10 +262,7 @@ def _subprocess(self, command: RCommand):
         if self.verbosity > 0:
             self.secho(" ".join(args), fg="cyan")
 
-        # todo make this async
-        result = subprocess.run(args, env=os.environ.copy(), capture_output=True)
-        self.stdout.write(result.stdout.decode())
-        self.stderr.write(result.stderr.decode())
+        result = subprocess.run(args, env=os.environ.copy())
         if result.returncode > 0:
             raise CommandError(
                 _(

doc/source/changelog.rst

@@ -8,6 +8,7 @@ v1.3.0 (2024-02-18)
 
 * Implemented `Remove support for python 3.8 <https://github.com/bckohan/django-render-static/issues/30>`_
 * Implemented `Upgrade to django-typer 3.x <https://github.com/bckohan/django-render-static/issues/29>`_
+* Implemented `stdout/stderr streaming from subprocesses <https://github.com/bckohan/django-render-static/issues/15>`_
 
 v1.2.1 (2024-08-26)
 ===================

tests/settings_option_toggle.py

@@ -0,0 +1,15 @@
+from .base_settings import *
+from django_routines import routine, RoutineCommand
+
+
+routine(
+    "option-on",
+    "Test what happens when supplied command option is toggled on.",
+    RoutineCommand("collectstatic", options={"interactive": False}),
+)
+
+routine(
+    "option-off",
+    "Test what happens when supplied command option is toggled off.",
+    RoutineCommand("collectstatic", options={"interactive": True}),
+)

tests/test_runs.py

@@ -7,6 +7,7 @@
 import subprocess
 from django.core.management import call_command
 from django.test import TestCase
+import pexpect
 
 
 class TestDeploy(TestCase):
@@ -56,3 +57,37 @@ def test_subprocess_opt_error():
         "CommandError: Failed to convert collectstatic options to CLI format: {'not-an-option': False}"
         in result.stderr
     )
+
+
+def test_option_toggle():
+    child = pexpect.spawn(
+        " ".join(
+            [
+                sys.executable,
+                "./manage.py",
+                "routine",
+                "--settings",
+                "tests.settings_option_toggle",
+                "option-on",
+                "--subprocess",
+            ]
+        )
+    )
+    child.expect("static files copied.")
+
+    child = pexpect.spawn(
+        " ".join(
+            [
+                sys.executable,
+                "./manage.py",
+                "routine",
+                "--settings",
+                "tests.settings_option_toggle",
+                "option-off",
+                "--subprocess",
+            ]
+        )
+    )
+    child.expect("Type 'yes' to continue, or 'no' to cancel:")
+    child.sendline("yes")
+    child.expect("static files copied.")