Skip to content

Commit 5afdd36

Browse files
authored
Merge pull request #209 from bcgsc/release/v6.10.2
Release/v6.10.2
2 parents 8e4ed08 + 89dd0fb commit 5afdd36

File tree

5 files changed

+22
-8
lines changed

5 files changed

+22
-8
lines changed

app/components/Image/index.tsx

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ const Image = ({
2424
format,
2525
key,
2626
} = {} as ImageType,
27-
height = undefined,
28-
width = undefined,
27+
height: heightProp = undefined,
28+
width: widthProp = undefined,
2929
showTitle = false,
3030
showCaption = false,
3131
isZoomable = true,
@@ -39,6 +39,15 @@ const Image = ({
3939
}
4040
}, [isZoomable]);
4141

42+
let height = heightProp;
43+
let width = widthProp;
44+
if (heightProp && Number.isInteger(heightProp)) {
45+
height = `${heightProp}px`;
46+
}
47+
if (widthProp && Number.isInteger(widthProp)) {
48+
width = `${widthProp}px`;
49+
}
50+
4251
if (data) {
4352
return (
4453
<>
@@ -58,8 +67,8 @@ const Image = ({
5867
src={`data:image/${format};base64,${data}`}
5968
alt={title}
6069
key={key}
61-
height={Number.isInteger(height) ? `${height}px` : height}
62-
width={Number.isInteger(width) ? `${height}px` : width}
70+
height={height}
71+
width={width}
6372
style={imgStyle}
6473
/>
6574
</Button>

app/components/PrintTable/index.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
&__row {
2020
font-size: 10pt;
2121
border-bottom: 1px solid $palette__text--hint;
22+
page-break-inside: avoid;
2223

2324
& td {
2425
padding: 10px 4px;

app/views/ReportView/components/ExpressionCorrelation/index.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ const EXPRESSION_KEYS = [
3535
{ key: 'expression.spearman.gtex', title: 'GTEX' },
3636
];
3737

38+
const DEFAULT_IMG_WIDTH = 800;
39+
3840
type ExpressionCorrelationProps = WithLoadingInjectedProps;
3941

4042
const ExpressionCorrelation = ({
@@ -89,6 +91,7 @@ const ExpressionCorrelation = ({
8991
<PlotByKey
9092
accessor={group.key}
9193
plots={plots}
94+
width={DEFAULT_IMG_WIDTH}
9295
/>
9396
</div>
9497
))}
@@ -118,8 +121,7 @@ const ExpressionCorrelation = ({
118121
<div className="expression-correlation__expression-charts">
119122
{sampleExpressionCharts(plots.find((plot) => plot.key === 'expression.chart')
120123
? LEGACY_EXPRESSION_KEYS
121-
: EXPRESSION_KEYS)
122-
}
124+
: EXPRESSION_KEYS)}
123125
</div>
124126
</div>
125127
{/* This section should only appear if there's data */}
@@ -134,6 +136,7 @@ const ExpressionCorrelation = ({
134136
<PlotByKey
135137
plots={plots}
136138
accessor="scpPlot"
139+
width={DEFAULT_IMG_WIDTH}
137140
/>
138141
</div>
139142
</div>
@@ -154,6 +157,7 @@ const ExpressionCorrelation = ({
154157
image={plot}
155158
showTitle
156159
showCaption
160+
width={DEFAULT_IMG_WIDTH}
157161
/>
158162
))}
159163
</div>

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"private": true,
33
"name": "ipr-client",
4-
"version": "6.10.1",
4+
"version": "6.10.2",
55
"keywords": [],
66
"license": "GPL-3.0",
77
"sideEffects": false,

0 commit comments

Comments
 (0)