From bf2d3644c5c1966d55bc5e386517d86c0c74006a Mon Sep 17 00:00:00 2001 From: Eason Pan Date: Fri, 20 Jun 2025 09:07:36 -0700 Subject: [PATCH 1/6] update specs matching the validation updates --- web/site/public/br/business-spec.yaml | 36 ++++++++++++++++++++++----- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/web/site/public/br/business-spec.yaml b/web/site/public/br/business-spec.yaml index fb9853e..4ec2e71 100644 --- a/web/site/public/br/business-spec.yaml +++ b/web/site/public/br/business-spec.yaml @@ -4108,7 +4108,8 @@ components: type: object required: - registeredOffice - description: 'Addresses related to the business. ' + - recordsOffice + description: 'Addresses related to the business.' properties: registeredOffice: $ref: '#/components/schemas/Office' @@ -4199,10 +4200,20 @@ components: required: - officer - deliveryAddress + - mailingAddress - appointmentDate - cessationDate offices: - $ref: '#/components/schemas/Office' + type: object + required: + - registeredOffice + - recordsOffice + description: 'Addresses related to the business.' + properties: + registeredOffice: + $ref: '#/components/schemas/Office' + recordsOffice: + $ref: '#/components/schemas/Office' required: - annualReport x-examples: @@ -4861,6 +4872,7 @@ components: files: type: array minItems: 1 + maxItems: 5 items: required: - fileKey @@ -4888,7 +4900,7 @@ components: $ref: '#/components/schemas/Name_translations' offices: type: object - description: 'Addresses related to the business. ' + description: 'Addresses related to the business.' properties: registeredOffice: $ref: '#/components/schemas/Office' @@ -4896,6 +4908,7 @@ components: $ref: '#/components/schemas/Office' required: - registeredOffice + - recordsOffice parties: type: array description: 'Persons having a role in the corporation eg: company officer.' @@ -4944,11 +4957,11 @@ components: type: string format: phone example: (250) 234-4433 - description: 'Phone number to be used to contact the business eg: (250) 234-4433.' + description: 'Phone number to be used to contact the business eg: (250) 234-4433, maximum 10 digits' extension: type: number example: 123 - description: Extension number of the business contact phone number (555) 555-5555. + description: 'Extension number of the business contact phone number (555) 555-5555, maximum 5 digits' required: - email Conversion: @@ -6102,12 +6115,15 @@ components: $ref: '#/components/schemas/Name_translations' offices: type: object - description: 'Addresses related to the business. ' + description: 'Addresses related to the business.' properties: registeredOffice: $ref: '#/components/schemas/Office' recordsOffice: $ref: '#/components/schemas/Office' + required: + - registeredOffice + - recordsOffice parties: type: array description: 'Persons having a role in the corporation eg: company director.' @@ -6583,6 +6599,10 @@ components: title: Person Schema description: 'An individual that is currently or had previously occupied a role in relation to a business.' properties: + firstName: + type: string + maxLength: 30 + description: 'First name of the individual. Used in corporations filings.' givenName: type: string maxLength: 30 @@ -6591,6 +6611,10 @@ components: type: string maxLength: 30 description: Last name or surname of the individual. + lastName: + type: string + maxLength: 30 + description: 'Last name or surname of the individual. Used in corporations filings.' additionalName: type: string title: 'An additional name for a Person, can be used for a middle name.' From 7df7be3b9800a07a9f30e6476d5c879d0a328fb6 Mon Sep 17 00:00:00 2001 From: Eason Pan Date: Fri, 20 Jun 2025 09:09:32 -0700 Subject: [PATCH 2/6] Revert "update specs matching the validation updates" This reverts commit bf2d3644c5c1966d55bc5e386517d86c0c74006a. --- web/site/public/br/business-spec.yaml | 36 +++++---------------------- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/web/site/public/br/business-spec.yaml b/web/site/public/br/business-spec.yaml index 4ec2e71..fb9853e 100644 --- a/web/site/public/br/business-spec.yaml +++ b/web/site/public/br/business-spec.yaml @@ -4108,8 +4108,7 @@ components: type: object required: - registeredOffice - - recordsOffice - description: 'Addresses related to the business.' + description: 'Addresses related to the business. ' properties: registeredOffice: $ref: '#/components/schemas/Office' @@ -4200,20 +4199,10 @@ components: required: - officer - deliveryAddress - - mailingAddress - appointmentDate - cessationDate offices: - type: object - required: - - registeredOffice - - recordsOffice - description: 'Addresses related to the business.' - properties: - registeredOffice: - $ref: '#/components/schemas/Office' - recordsOffice: - $ref: '#/components/schemas/Office' + $ref: '#/components/schemas/Office' required: - annualReport x-examples: @@ -4872,7 +4861,6 @@ components: files: type: array minItems: 1 - maxItems: 5 items: required: - fileKey @@ -4900,7 +4888,7 @@ components: $ref: '#/components/schemas/Name_translations' offices: type: object - description: 'Addresses related to the business.' + description: 'Addresses related to the business. ' properties: registeredOffice: $ref: '#/components/schemas/Office' @@ -4908,7 +4896,6 @@ components: $ref: '#/components/schemas/Office' required: - registeredOffice - - recordsOffice parties: type: array description: 'Persons having a role in the corporation eg: company officer.' @@ -4957,11 +4944,11 @@ components: type: string format: phone example: (250) 234-4433 - description: 'Phone number to be used to contact the business eg: (250) 234-4433, maximum 10 digits' + description: 'Phone number to be used to contact the business eg: (250) 234-4433.' extension: type: number example: 123 - description: 'Extension number of the business contact phone number (555) 555-5555, maximum 5 digits' + description: Extension number of the business contact phone number (555) 555-5555. required: - email Conversion: @@ -6115,15 +6102,12 @@ components: $ref: '#/components/schemas/Name_translations' offices: type: object - description: 'Addresses related to the business.' + description: 'Addresses related to the business. ' properties: registeredOffice: $ref: '#/components/schemas/Office' recordsOffice: $ref: '#/components/schemas/Office' - required: - - registeredOffice - - recordsOffice parties: type: array description: 'Persons having a role in the corporation eg: company director.' @@ -6599,10 +6583,6 @@ components: title: Person Schema description: 'An individual that is currently or had previously occupied a role in relation to a business.' properties: - firstName: - type: string - maxLength: 30 - description: 'First name of the individual. Used in corporations filings.' givenName: type: string maxLength: 30 @@ -6611,10 +6591,6 @@ components: type: string maxLength: 30 description: Last name or surname of the individual. - lastName: - type: string - maxLength: 30 - description: 'Last name or surname of the individual. Used in corporations filings.' additionalName: type: string title: 'An additional name for a Person, can be used for a middle name.' From 22a26596dbb3dc1de61a9a8b78f07ffed9e44dc5 Mon Sep 17 00:00:00 2001 From: Eason Pan Date: Fri, 20 Jun 2025 09:12:03 -0700 Subject: [PATCH 3/6] update specs matching the validation updates --- web/site/public/br/business-spec.yaml | 36 ++++++++++++++++++++++----- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/web/site/public/br/business-spec.yaml b/web/site/public/br/business-spec.yaml index fb9853e..4ec2e71 100644 --- a/web/site/public/br/business-spec.yaml +++ b/web/site/public/br/business-spec.yaml @@ -4108,7 +4108,8 @@ components: type: object required: - registeredOffice - description: 'Addresses related to the business. ' + - recordsOffice + description: 'Addresses related to the business.' properties: registeredOffice: $ref: '#/components/schemas/Office' @@ -4199,10 +4200,20 @@ components: required: - officer - deliveryAddress + - mailingAddress - appointmentDate - cessationDate offices: - $ref: '#/components/schemas/Office' + type: object + required: + - registeredOffice + - recordsOffice + description: 'Addresses related to the business.' + properties: + registeredOffice: + $ref: '#/components/schemas/Office' + recordsOffice: + $ref: '#/components/schemas/Office' required: - annualReport x-examples: @@ -4861,6 +4872,7 @@ components: files: type: array minItems: 1 + maxItems: 5 items: required: - fileKey @@ -4888,7 +4900,7 @@ components: $ref: '#/components/schemas/Name_translations' offices: type: object - description: 'Addresses related to the business. ' + description: 'Addresses related to the business.' properties: registeredOffice: $ref: '#/components/schemas/Office' @@ -4896,6 +4908,7 @@ components: $ref: '#/components/schemas/Office' required: - registeredOffice + - recordsOffice parties: type: array description: 'Persons having a role in the corporation eg: company officer.' @@ -4944,11 +4957,11 @@ components: type: string format: phone example: (250) 234-4433 - description: 'Phone number to be used to contact the business eg: (250) 234-4433.' + description: 'Phone number to be used to contact the business eg: (250) 234-4433, maximum 10 digits' extension: type: number example: 123 - description: Extension number of the business contact phone number (555) 555-5555. + description: 'Extension number of the business contact phone number (555) 555-5555, maximum 5 digits' required: - email Conversion: @@ -6102,12 +6115,15 @@ components: $ref: '#/components/schemas/Name_translations' offices: type: object - description: 'Addresses related to the business. ' + description: 'Addresses related to the business.' properties: registeredOffice: $ref: '#/components/schemas/Office' recordsOffice: $ref: '#/components/schemas/Office' + required: + - registeredOffice + - recordsOffice parties: type: array description: 'Persons having a role in the corporation eg: company director.' @@ -6583,6 +6599,10 @@ components: title: Person Schema description: 'An individual that is currently or had previously occupied a role in relation to a business.' properties: + firstName: + type: string + maxLength: 30 + description: 'First name of the individual. Used in corporations filings.' givenName: type: string maxLength: 30 @@ -6591,6 +6611,10 @@ components: type: string maxLength: 30 description: Last name or surname of the individual. + lastName: + type: string + maxLength: 30 + description: 'Last name or surname of the individual. Used in corporations filings.' additionalName: type: string title: 'An additional name for a Person, can be used for a middle name.' From ea5294563756c8ab172e09d249fb65bdbfd4a44d Mon Sep 17 00:00:00 2001 From: Eason Pan Date: Fri, 20 Jun 2025 10:14:10 -0700 Subject: [PATCH 4/6] add descriptions to CoD addresses --- web/site/public/br/business-spec.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/web/site/public/br/business-spec.yaml b/web/site/public/br/business-spec.yaml index 4ec2e71..e0b36d2 100644 --- a/web/site/public/br/business-spec.yaml +++ b/web/site/public/br/business-spec.yaml @@ -5303,8 +5303,10 @@ components: - lastName deliveryAddress: $ref: '#/components/schemas/Address' + description: Required for Change of Directors filing and Annual Report filing. mailingAddress: $ref: '#/components/schemas/Address' + description: Required for Change of Directors filing and Annual Report filing. title: type: string description: 'Official title or position of the director in the company.' From db91c5e6006364d56104d109cdc00542a2b8e61f Mon Sep 17 00:00:00 2001 From: Eason Pan Date: Fri, 20 Jun 2025 10:16:20 -0700 Subject: [PATCH 5/6] add addresses original descriptions to CoD addresses --- web/site/public/br/business-spec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/site/public/br/business-spec.yaml b/web/site/public/br/business-spec.yaml index e0b36d2..46739c3 100644 --- a/web/site/public/br/business-spec.yaml +++ b/web/site/public/br/business-spec.yaml @@ -5303,10 +5303,10 @@ components: - lastName deliveryAddress: $ref: '#/components/schemas/Address' - description: Required for Change of Directors filing and Annual Report filing. + description: 'Standard address format: apartment, unit, or street address number and street name. City, province or territory code, country, postal code and instructions for delivery. Required for Change of Directors filing and Annual Report filing.' mailingAddress: $ref: '#/components/schemas/Address' - description: Required for Change of Directors filing and Annual Report filing. + description: 'Standard address format: apartment, unit, or street address number and street name. City, province or territory code, country, postal code and instructions for delivery.Required for Change of Directors filing and Annual Report filing.' title: type: string description: 'Official title or position of the director in the company.' From a5dc6a8fd31ba5eb6299f27ea491f948006aac43 Mon Sep 17 00:00:00 2001 From: Eason Pan Date: Fri, 20 Jun 2025 10:57:10 -0700 Subject: [PATCH 6/6] add the missed space in a description --- web/site/public/br/business-spec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/site/public/br/business-spec.yaml b/web/site/public/br/business-spec.yaml index 46739c3..767ec6c 100644 --- a/web/site/public/br/business-spec.yaml +++ b/web/site/public/br/business-spec.yaml @@ -5306,7 +5306,7 @@ components: description: 'Standard address format: apartment, unit, or street address number and street name. City, province or territory code, country, postal code and instructions for delivery. Required for Change of Directors filing and Annual Report filing.' mailingAddress: $ref: '#/components/schemas/Address' - description: 'Standard address format: apartment, unit, or street address number and street name. City, province or territory code, country, postal code and instructions for delivery.Required for Change of Directors filing and Annual Report filing.' + description: 'Standard address format: apartment, unit, or street address number and street name. City, province or territory code, country, postal code and instructions for delivery. Required for Change of Directors filing and Annual Report filing.' title: type: string description: 'Official title or position of the director in the company.'