ML-DSA vs Dilithium #1927

marsom · 2024-11-29T10:47:07Z

marsom
Nov 29, 2024

im propably messed up something but i hope you can help me.

i did some dilithium tests, created a key, signed it
with 1.79 this does not work anymore, i get a org.bouncycastle.operator.OperatorCreationException: cannot create signer: unknown private key passed to ML-DSA

is it correct that Dilithium key have been stadartisied an the new nams is ML-DSA?

Dilithium2 -> ML-DSA-44
Dilithium3 -> ML-DSA-65
Dilithium5 -> ML-DSA-87

package testing;

import org.bouncycastle.asn1.x500.X500Name;
import org.bouncycastle.cert.jcajce.JcaX509CertificateConverter;
import org.bouncycastle.cert.jcajce.JcaX509v3CertificateBuilder;
import org.bouncycastle.jcajce.spec.MLDSAParameterSpec;
import org.bouncycastle.jce.provider.BouncyCastleProvider;
import org.bouncycastle.openssl.jcajce.JcaPEMKeyConverter;
import org.bouncycastle.openssl.jcajce.JcaPEMWriter;
import org.bouncycastle.operator.OperatorCreationException;
import org.bouncycastle.operator.jcajce.JcaContentSignerBuilder;
import org.bouncycastle.pqc.jcajce.spec.DilithiumParameterSpec;
import org.junit.jupiter.api.Test;

import java.io.IOException;
import java.io.StringWriter;
import java.math.BigInteger;
import java.security.*;
import java.security.cert.CertificateException;
import java.util.Date;
import java.util.Random;

class KeyTypeScratchTest {

    public String toPEM(KeyPair keyPair, Provider provider) throws IOException {
        JcaPEMKeyConverter converter = new JcaPEMKeyConverter().setProvider(provider);

        StringWriter writer = new StringWriter();
        try (JcaPEMWriter pemWriter = new JcaPEMWriter(writer)) {
            pemWriter.writeObject(keyPair.getPrivate());
            pemWriter.flush();
        }

        return writer.toString();
    }


    @Test
    void dilitiuum() throws InvalidAlgorithmParameterException, NoSuchAlgorithmException, IOException, CertificateException, SignatureException, OperatorCreationException, InvalidKeyException, NoSuchProviderException {
        var bc = new BouncyCastleProvider();

        var keyPairGenerator = KeyPairGenerator.getInstance("Dilithium", bc);
        keyPairGenerator.initialize(DilithiumParameterSpec.dilithium3);
        var keyPair = keyPairGenerator.generateKeyPair();

        System.out.println(toPEM(keyPair, bc));

        var certificateBuilder = new JcaX509v3CertificateBuilder(
                new X500Name("CN=test"),
                BigInteger.valueOf(new Random().nextLong()),
                new Date(),
                new Date(),
                new X500Name("CN=test"),
                keyPair.getPublic()
        );

        var contentSignerBuilder = new JcaContentSignerBuilder("Dilithium").setProvider(bc);
        var certHolder = certificateBuilder.build(contentSignerBuilder.build(keyPair.getPrivate()));

        var certConverter = new JcaX509CertificateConverter().setProvider(bc);
        var cert = certConverter.getCertificate(certHolder);

        cert.verify(keyPair.getPublic());

    }

    @Test
    void mldsa() throws InvalidAlgorithmParameterException, NoSuchAlgorithmException, IOException, CertificateException, SignatureException, OperatorCreationException, InvalidKeyException, NoSuchProviderException {
        var bc = new BouncyCastleProvider();

        var keyPairGenerator = KeyPairGenerator.getInstance("ML-DSA", bc);
        keyPairGenerator.initialize(MLDSAParameterSpec.ml_dsa_65);
        var keyPair = keyPairGenerator.generateKeyPair();

        System.out.println(toPEM(keyPair, bc));

        var certificateBuilder = new JcaX509v3CertificateBuilder(
                new X500Name("CN=test"),
                BigInteger.valueOf(new Random().nextLong()),
                new Date(),
                new Date(),
                new X500Name("CN=test"),
                keyPair.getPublic()
        );

        var contentSignerBuilder = new JcaContentSignerBuilder("ML-DSA-65").setProvider(bc);
        var certHolder = certificateBuilder.build(contentSignerBuilder.build(keyPair.getPrivate()));

        var certConverter = new JcaX509CertificateConverter().setProvider(bc);
        var cert = certConverter.getCertificate(certHolder);

        cert.verify(keyPair.getPublic());

    }

}

im a bit confused, a dilithum encoded keys lools like this

and a ml-dsa looks like this

-----BEGIN PRIVATE KEY-----
MDQCAQAwCwYJYIZIAWUDBAMSBCIEIOyNQTrbRCulYU7r0K4lD5LwK7a++FL0PX3e
rO7TPLZD
-----END PRIVATE KEY-----

this looks not ok for me, how could so small key repalce the other one? therefore i assume my assumtion the ml-dsa-* are the new dilitium keys is probably wrong.

marsom · 2024-11-29T15:39:35Z

marsom
Nov 29, 2024
Author

ok I debbuged a more, I beleave that bc cannot a correct pkcs8 pem file out of a ML-DSA key, ie. if i compare a key https://asecuritysite.com/signatures/mldsa_js then they look much bigger than the bc generated ones

0 replies

marsom · 2024-12-09T13:10:11Z

marsom
Dec 9, 2024
Author

docker run -ti --rm  openquantumsafe/openssl3 openssl genpkey -algorithm mldsa44

also generates much bigger pem files.

0 replies

marsom · 2024-12-09T13:13:01Z

marsom
Dec 9, 2024
Author

moved to a issue

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ML-DSA vs Dilithium #1927

Uh oh!

{{title}}

Uh oh!

Replies: 3 comments

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

ML-DSA vs Dilithium #1927

Uh oh!

marsom Nov 29, 2024

Replies: 3 comments

Uh oh!

Uh oh!

marsom Nov 29, 2024 Author

Uh oh!

Uh oh!

marsom Dec 9, 2024 Author

Uh oh!

marsom Dec 9, 2024 Author

marsom
Nov 29, 2024

marsom
Nov 29, 2024
Author

marsom
Dec 9, 2024
Author

marsom
Dec 9, 2024
Author