Skip to content

Commit 7f5ef55

Browse files
committed
#551: verify parsing 7bit with spacing works just fine
1 parent a83c511 commit 7f5ef55

File tree

2 files changed

+31
-5
lines changed

2 files changed

+31
-5
lines changed

modules/simple-java-mail/src/test/java/org/simplejavamail/converter/EmailConverterTest.java

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ public void testAttachmentSize() {
160160
assertThat(email.getAttachments()).hasSize(2);
161161
assertThat(email.getAttachments()).extracting("name").containsExactly("ForwardedMessage.eml", "ForwardedMessage.eml");
162162
}
163-
163+
164164
@Test
165165
public void testOutlookMessageWithEmptyAttachments() {
166166
Email s1 = EmailConverter.outlookMsgToEmail(new File(RESOURCE_TEST_MESSAGES + "/#318 Email with nodata-attachment.msg"));
@@ -401,17 +401,24 @@ public void testGithub486_InvalidSignedOutlookMessage() {
401401
public void testGithub491_EmailWithMultiPurposeAttachments() {
402402
Email emailMime = EmailConverter.emlToEmail(new File(RESOURCE_TEST_MESSAGES + "/#491 Email with dual purpose datasources.eml"));
403403

404-
assertThat(emailMime.getEmbeddedImages()).satisfiesExactly(
404+
assertThat(emailMime.getEmbeddedImages()).satisfiesExactly(
405405
at -> {
406-
at.getName().equals("ii_lrkua30a0");
407-
at.getDataSource().getName().equals("doclife.jpg");
408-
});
406+
at.getName().equals("ii_lrkua30a0");
407+
at.getDataSource().getName().equals("doclife.jpg");
408+
});
409409
assertThat(emailMime.getAttachments()).satisfiesExactlyInAnyOrder(
410410
at -> at.getName().equals("Il Viaggio delle Ombre.pdf"),
411411
at -> at.getName().equals("Nyan Cat! [Official]-(480p).mp4"),
412412
at -> at.getName().equals("doclife.jpg"));
413413
}
414414

415+
@Test
416+
public void testGithub551_ContentTransferEncodingEndsWithSpaceBug() {
417+
Email emailMime = EmailConverter.emlToEmail(new File(RESOURCE_TEST_MESSAGES + "/#551 Email with extra space in Content-Transfer-Encoding.eml"));
418+
419+
assertThat(emailMime.getContentTransferEncoding()).isEqualTo(BIT7);
420+
}
421+
415422
@NotNull
416423
private List<AttachmentResource> asList(AttachmentResource attachment) {
417424
List<AttachmentResource> collectionAttachment = new ArrayList<>();
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
Date: Thu, 26 Sep 2024 23:36:58 -0400
2+
To: <xxx@gmail.com>
3+
Subject: test
4+
From: <yyy@gmail.com>
5+
Message-ID: <014624BC-D114-4473-b1f6-F4ec3E0e28d4@ind1311mtd400.yz.xxxx>
6+
Content-Type: multipart/alternative;
7+
boundary="2cu1j27uX5Y7=_?:"
8+
9+
--2cu1j27uX5Y7=_?:
10+
Content-Type: text/plain; charset="utf-8"
11+
Content-Transfer-Encoding: 7bit
12+
13+
text plain
14+
--2cu1j27uX5Y7=_?:
15+
Content-Type: text/html; charset="utf-8"
16+
Content-Transfer-Encoding: 7bit
17+
18+
text html
19+
--2cu1j27uX5Y7=_?:--

0 commit comments

Comments
 (0)