Skip to content

Handling phone numbers with spaces in it #743

@Pheggas

Description

@Pheggas

The problem

Hello. I just discovered issue of sending message to some phone number that has spaces in it. Specifically, for example i have phone number of +420 xxx xxx xxx. If i send POST request to /v2/send with payload of:

{
  "message":"test from kubernetes",
  "number":"+420xxxxxxxx0",
  "recipients": [
    "+420 xxx xxx xx1"
  ]
}

it returns response of:

{
  "error": "java.lang.NullPointerException: Cannot invoke \"org.asamk.signal.manager.storage.recipients.RecipientId.id()\" because \"recipientId\" is null\n\tat org.asamk.signal.manager.storage.recipients.RecipientStore.getContact(RecipientStore.java:1471)\n\tat org.asamk.signal.manager.storage.recipients.RecipientStore.getContact(RecipientStore.java:330)\n\tat org.asamk.signal.manager.helper.SendHelper.sendMessage(SendHelper.java:82)\n\tat org.asamk.signal.manager.internal.ManagerImpl.sendMessage(ManagerImpl.java:653)\n\tat org.asamk.signal.manager.internal.ManagerImpl.sendMessage(ManagerImpl.java:627)\n\tat org.asamk.signal.manager.internal.ManagerImpl.sendMessage(ManagerImpl.java:762)\n\tat org.asamk.signal.commands.SendCommand.handleCommand(SendCommand.java:255)\n\tat org.asamk.signal.commands.CommandHandler.handleLocalCommand(CommandHandler.java:37)\n\tat org.asamk.signal.App.handleLocalCommand(App.java:281)\n\tat org.asamk.signal.App.handleCommand(App.java:182)\n\tat org.asamk.signal.App.init(App.java:147)\n\tat org.asamk.signal.Main.main(Main.java:56)\n"
}

but in case i do not enter any spaces into the number value, the message sends just fine.

Are you using the latest released version?

  • Yes

Have you read the troubleshooting page?

  • Yes

What type of installation are you running?

signal-cli-rest-api Docker Container

In which mode are you using the docker container?

Normal Mode

What's the architecture of your host system?

x86-64

Additional information

I wrapped the docker container into kubernetes deployment so i could deploy it in my k8s cluster. Using version 0.94.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions