Skip to content

Commit af47fb8

Browse files
committed
Merge branch 'master' of https://github.com/bbc/bigscreen-player into badgers-655-lowlatency-metrics
2 parents a60bf84 + b0e8551 commit af47fb8

File tree

4 files changed

+218
-94
lines changed

4 files changed

+218
-94
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "bigscreen-player",
3-
"version": "10.5.0",
3+
"version": "10.5.1",
44
"type": "module",
55
"description": "Simplified media playback for bigscreen devices.",
66
"main": "dist/esm/main.js",

src/playbackstrategy/msestrategy.js

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -513,13 +513,16 @@ function MSEStrategy(
513513
function onCurrentTrackChanged(event) {
514514
if (!isAudioDescribedAvailable()) return
515515

516+
audioDescribed.enable = isAudioDescribedEnabled()
516517
const mediaType = event.newMediaInfo.type
518+
517519
DebugTool.info(
518520
`${mediaType} track changed.${
519-
mediaType === "audio" ? (isAudioDescribedEnabled() ? " Audio Described on." : " Audio Described off.") : ""
521+
mediaType === "audio" ? (audioDescribed.enable ? " Audio Described on." : " Audio Described off.") : ""
520522
}`
521523
)
522-
audioDescribed.callback && audioDescribed.callback(isAudioDescribedEnabled())
524+
525+
audioDescribed.callback && audioDescribed.callback(audioDescribed.enable)
523526
}
524527

525528
function publishMediaState(mediaState) {
@@ -591,6 +594,16 @@ function MSEStrategy(
591594

592595
mediaPlayer.initialize(mediaElement, null)
593596

597+
modifySource(presentationTimeInSeconds)
598+
}
599+
600+
function modifySource(presentationTimeInSeconds) {
601+
if (mediaPlayer.isReady()) {
602+
// Reset source to apply media settings for the new source
603+
// dash.js will reset media settings if a new source is attached while its initialised with a source
604+
mediaPlayer.attachSource(null)
605+
}
606+
594607
mediaPlayer.setInitialMediaSettingsFor(
595608
"audio",
596609
audioDescribed.enable
@@ -603,10 +616,6 @@ function MSEStrategy(
603616
}
604617
)
605618

606-
modifySource(presentationTimeInSeconds)
607-
}
608-
609-
function modifySource(presentationTimeInSeconds) {
610619
const source = mediaSources.currentSource()
611620
const anchor = buildSourceAnchor(presentationTimeInSeconds)
612621

0 commit comments

Comments
 (0)