Skip to content

Crate vendoring hangs indefinitely upon proxy issues #3557

@felixmulder

Description

@felixmulder

Hi!

We (Stripe) noticed that when vendoring crates cargo-bazel will hang forever in:

let output = self
.cargo_bin
.command()?
// Cargo detects config files based on `pwd` when running so
// to ensure user provided Cargo config files are used, it's
// critical to set the working directory to the manifest dir.
.current_dir(manifest_dir.as_std_path())
.arg("fetch")
.arg("--manifest-path")
.arg(manifest_path.as_std_path())
.arg("--verbose")
.output()
.context(format!(
"Error running cargo to fetch crates '{}'",
manifest_path
))?;

due to the cargo commands not being configured with timeouts. Low-hanging fruit here would be setting some default timeouts here that make sense ☺️

Thanks for an awesome ruleset!

// F

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions