Skip to content

Conversation

@jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Oct 23, 2025

This is the first BCR version of https://github.com/RobotLocomotion/ruff_prebuilt.

See also astral-sh/ruff#20672.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (ruff_prebuilt) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the new module ruff_prebuilt at version 0.14.1.1. The submission largely follows the Bazel Central Registry guidelines. My main feedback is to broaden the bazel_compatibility from Bazel 8+ to include Bazel 7, the current LTS release, to make the module accessible to more users. I've included suggestions to update MODULE.bazel and the presubmit.yml test matrices accordingly. Since this is a new module, a review of the maintainers and repository fields in metadata.json by @bazelbuild/bcr-maintainers is advised as per the contribution guide.

@jwnimmer-tri
Copy link
Contributor Author

jwnimmer-tri commented Oct 23, 2025

@gemini-code-assist For a completely new module, I am not going to test and support versions of bazel other than the most recent LTS (8). Onwards.

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 23, 2025
@jwnimmer-tri jwnimmer-tri changed the title ruff_prebuilt@0.14.1.1 ruff_prebuilt@0.14.1.2 Oct 23, 2025
@jwnimmer-tri jwnimmer-tri changed the title ruff_prebuilt@0.14.1.2 ruff_prebuilt@0.14.1.3 Oct 23, 2025
@Wyverald Wyverald merged commit 7a1bb3d into bazelbuild:main Oct 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants