Fix "no-floating-promises" violations (#228)

* Fix "no-floating-promises" violations

This change adds support for the "no-floating-promises" lint check.
Adding this check required the commandline tslint to explicitly
specify the project, which is required to enable type checking.

Without this change, simply adding the lint check would result in the
following warning:

 - Warning: The 'no-floating-promises' rule requires type information.

I also fixed all existing violations in the codebase.

* Fix other "no-floating-promises" violations

Co-authored-by: Philipp Wollermann <philwo@google.com>
Co-authored-by: Chi Wang <chiwang@google.com>

Author: 3 people

package.json

@@ -357,7 +357,7 @@
         }
     },
     "scripts": {
-        "check-lint": "tslint -t stylish 'src/**/*.ts' --exclude 'src/**/*.d.ts'",
+        "check-lint": "tslint --project tsconfig.json -t stylish 'src/**/*.ts' --exclude 'src/**/*.d.ts'",
         "compile": "./scripts/build.sh",
         "vscode:prepublish": "./scripts/build.sh",
         "watch": "./scripts/build.sh -watch"

src/buildifier/buildifier_availability.ts

@@ -54,6 +54,7 @@ export function checkBuildifierIsAvailable() {
           }
         }
         // If we didn't get valid JSON back, we don't have a compatible version.
+        // tslint:disable-next-line:no-floating-promises
         showBuildifierDownloadPrompt(
           "Buildifier is too old (0.25.1 or higher is needed)",
         );

src/buildifier/buildifier_diagnostics_manager.ts

@@ -46,6 +46,7 @@ export class BuildifierDiagnosticsManager implements vscode.Disposable {
         clearTimeout(didChangeTextTimer);
       }
       didChangeTextTimer = setTimeout(() => {
+        // tslint:disable-next-line:no-floating-promises
         this.updateDiagnostics(e.document);
         didChangeTextTimer = null;
       }, DIAGNOSTICS_ON_TYPE_DELAY_MILLIS);
@@ -55,12 +56,14 @@ export class BuildifierDiagnosticsManager implements vscode.Disposable {
       if (!e) {
         return;
       }
+      // tslint:disable-next-line:no-floating-promises
       this.updateDiagnostics(e.document);
     });
 
     // If there is an active window at the time the manager is created, make
     // sure its diagnostics are computed.
     if (vscode.window.activeTextEditor) {
+      // tslint:disable-next-line:no-floating-promises
       this.updateDiagnostics(vscode.window.activeTextEditor.document);
     }
   }

src/debug-adapter/client.ts

@@ -265,7 +265,7 @@ class BazelDebugSession extends DebugSession {
       setBreakpoints: skylark_debugging.SetBreakpointsRequest.create({
         breakpoint: bazelBreakpoints,
       }),
-    });
+    }).catch((err) => this.debugLog("Error setting breakpoint: " + err));
     this.sendResponse(response);
   }
 
@@ -485,7 +485,7 @@ class BazelDebugSession extends DebugSession {
         stepping,
         threadId,
       }),
-    });
+    }).catch((err) => this.debugLog("Error continuing execution: " + err));
   }
 
   /**

src/extension/extension.ts

@@ -50,6 +50,7 @@ export function activate(context: vscode.ExtensionContext) {
   const buildifierDiagnostics = new BuildifierDiagnosticsManager();
   const completionItemProvider = new BazelCompletionItemProvider();
 
+  // tslint:disable-next-line:no-floating-promises
   completionItemProvider.refresh();
 
   context.subscriptions.push(
@@ -82,6 +83,7 @@ export function activate(context: vscode.ExtensionContext) {
     ),
     vscode.commands.registerCommand("bazel.clean", bazelClean),
     vscode.commands.registerCommand("bazel.refreshBazelBuildTargets", () => {
+      // tslint:disable-next-line:no-floating-promises
       completionItemProvider.refresh();
       workspaceTreeProvider.refresh();
     }),
@@ -155,7 +157,7 @@ async function bazelBuildTarget(adapter: IBazelCommandAdapter | undefined) {
     // If the result was undefined, the user cancelled the quick pick, so don't
     // try again.
     if (quickPick) {
-      bazelBuildTarget(quickPick);
+      await bazelBuildTarget(quickPick);
     }
     return;
   }
@@ -186,13 +188,12 @@ async function bazelBuildTargetWithDebugging(
     // If the result was undefined, the user cancelled the quick pick, so don't
     // try again.
     if (quickPick) {
-      bazelBuildTargetWithDebugging(quickPick);
+      await bazelBuildTargetWithDebugging(quickPick);
     }
     return;
   }
-  const bazelConfigCmdLine = vscode.workspace.getConfiguration(
-    "bazel.commandLine",
-  );
+  const bazelConfigCmdLine =
+    vscode.workspace.getConfiguration("bazel.commandLine");
   const startupOptions = bazelConfigCmdLine.get<string[]>("startupOptions");
   const commandArgs = bazelConfigCmdLine.get<string[]>("commandArgs");
 
@@ -221,7 +222,7 @@ async function bazelBuildTargetWithDebugging(
  *     which the command's arguments will be determined.
  */
 async function bazelbuildAll(adapter: IBazelCommandAdapter | undefined) {
-  buildPackage(":all", adapter);
+  await buildPackage(":all", adapter);
 }
 
 /**
@@ -233,7 +234,7 @@ async function bazelbuildAll(adapter: IBazelCommandAdapter | undefined) {
 async function bazelbuildAllRecursive(
   adapter: IBazelCommandAdapter | undefined,
 ) {
-  buildPackage("/...", adapter);
+  await buildPackage("/...", adapter);
 }
 
 async function buildPackage(
@@ -253,7 +254,7 @@ async function buildPackage(
     // If the result was undefined, the user cancelled the quick pick, so don't
     // try again.
     if (quickPick) {
-      buildPackage(suffix, quickPick);
+      await buildPackage(suffix, quickPick);
     }
     return;
   }
@@ -287,7 +288,7 @@ async function bazelTestTarget(adapter: IBazelCommandAdapter | undefined) {
     // If the result was undefined, the user cancelled the quick pick, so don't
     // try again.
     if (quickPick) {
-      bazelTestTarget(quickPick);
+      await bazelTestTarget(quickPick);
     }
     return;
   }
@@ -303,7 +304,7 @@ async function bazelTestTarget(adapter: IBazelCommandAdapter | undefined) {
  *     which the command's arguments will be determined.
  */
 async function bazelTestAll(adapter: IBazelCommandAdapter | undefined) {
-  testPackage(":all", adapter);
+  await testPackage(":all", adapter);
 }
 
 /**
@@ -315,7 +316,7 @@ async function bazelTestAll(adapter: IBazelCommandAdapter | undefined) {
 async function bazelTestAllRecursive(
   adapter: IBazelCommandAdapter | undefined,
 ) {
-  testPackage("/...", adapter);
+  await testPackage("/...", adapter);
 }
 
 async function testPackage(
@@ -335,7 +336,7 @@ async function testPackage(
     // If the result was undefined, the user cancelled the quick pick, so don't
     // try again.
     if (quickPick) {
-      testPackage(suffix, quickPick);
+      await testPackage(suffix, quickPick);
     }
     return;
   }

tslint.json

@@ -11,7 +11,8 @@
                 "limit": 80,
                 "ignore-pattern": "^import |^export {(.*?)}"
             }
-        ]
+        ],
+        "no-floating-promises": true
     },
     "rulesDirectory": []
 }