Skip to content

Commit 6338b37

Browse files
committed
fix: patch from @dzbarsky
1 parent 8f3a657 commit 6338b37

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

e2e/headers/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ cc_test(
22
name = "using_headers_test",
33
srcs = ["using_headers.cc"],
44
copts = select({
5-
"@platforms//os:windows": ["/std:c++14"],
6-
"//conditions:default": ["-std=c++14"],
5+
"@platforms//os:windows": ["/std:c++17"],
6+
"//conditions:default": ["-std=c++17"],
77
}),
88
target_compatible_with = select({
99
# Windows does not ship headers in the release artifact so this won't work yet.

nodejs/private/current_node_cc_headers.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ cc_library(
4242
name = "foo",
4343
srcs = ["foo.cc"],
4444
# If toolchain sets this already, you can omit.
45-
copts = ["-std=c++14"],
45+
copts = ["-std=c++17"],
4646
deps = ["@rules_nodejs//nodejs/headers:current_node_cc_headers"]
4747
)
4848
```

nodejs/repositories.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,7 @@ cc_library(
275275
# -> no results ...
276276
allow_empty = True,
277277
),
278+
copts = ["-std=c++17"],
278279
includes = ["bin/nodejs/include/node"],
279280
)
280281
"""

0 commit comments

Comments
 (0)