style(clang-tidy): fix bugprone-return-const-ref-from-parameter errors (sourcemeta#1732)

Fixes sourcemeta#1657

Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Co-authored-by: Juan Cruz Viotti <jv@jviotti.com>

Author: bavulapati

src/core/jsonpointer/include/sourcemeta/core/jsonpointer.h

@@ -74,6 +74,15 @@ using PointerTemplate = GenericPointerTemplate<Pointer>;
 SOURCEMETA_CORE_JSONPOINTER_EXPORT
 auto get(const JSON &document, const Pointer &pointer) -> const JSON &;
 
+// Constant reference parameters can accept xvalues which will be destructed
+// after the call. When the function returns such a parameter also as constant
+// reference, then the returned reference can be used after the object it refers
+// to has been destroyed.
+// https://clang.llvm.org/extra/clang-tidy/checks/bugprone/return-const-ref-from-parameter.html
+// This overload avoids mis-uses of retuning const reference parameter as
+// constant reference.
+auto get(JSON &&document, const Pointer &pointer) -> const JSON & = delete;
+
 /// @ingroup jsonpointer
 /// Get a value from a JSON document using a JSON WeakPointer (`const`
 /// overload).
@@ -98,6 +107,15 @@ auto get(const JSON &document, const Pointer &pointer) -> const JSON &;
 SOURCEMETA_CORE_JSONPOINTER_EXPORT
 auto get(const JSON &document, const WeakPointer &pointer) -> const JSON &;
 
+// Constant reference parameters can accept xvalues which will be destructed
+// after the call. When the function returns such a parameter also as constant
+// reference, then the returned reference can be used after the object it refers
+// to has been destroyed.
+// https://clang.llvm.org/extra/clang-tidy/checks/bugprone/return-const-ref-from-parameter.html
+// This overload avoids mis-uses of retuning const reference parameter as
+// constant reference.
+auto get(JSON &&document, const WeakPointer &pointer) -> const JSON & = delete;
+
 /// @ingroup jsonpointer
 /// Get a value from a JSON document using a Pointer, returning an optional that
 /// is not set if the path does not exist in the document. For example: