style(clang-tidy): fix cppcoreguidelines-pro-type-member-init errors (sourcemeta#1746)

fixes sourcemeta#1670

Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>

Author: bavulapati

src/core/jsonl/include/sourcemeta/core/jsonl_iterator.h

@@ -39,7 +39,7 @@ class SOURCEMETA_CORE_JSONL_EXPORT ConstJSONLIterator {
   std::uint64_t line{1};
   std::uint64_t column{0};
   auto parse_next() -> JSON;
-  std::basic_istream<JSON::Char, JSON::CharTraits> *data;
+  std::basic_istream<JSON::Char, JSON::CharTraits> *data{};
 
 // Exporting symbols that depends on the standard C++ library is considered
 // safe.
@@ -50,7 +50,7 @@ class SOURCEMETA_CORE_JSONL_EXPORT ConstJSONLIterator {
   // Use PIMPL idiom to hide internal details, mainly
   // templated members, which are tricky to DLL-export.
   struct Internal;
-  std::unique_ptr<Internal> internal;
+  std::unique_ptr<Internal> internal{};
 #if defined(_MSC_VER)
 #pragma warning(default : 4251)
 #endif

src/core/jsonschema/frame.cc

@@ -258,10 +258,10 @@ auto traverse_origin_instance_locations(
 }
 
 struct CacheSubschema {
-  const sourcemeta::core::PointerTemplate instance_location;
-  const sourcemeta::core::PointerTemplate relative_instance_location;
-  const bool orphan;
-  const std::optional<sourcemeta::core::Pointer> parent;
+  const sourcemeta::core::PointerTemplate instance_location{};
+  const sourcemeta::core::PointerTemplate relative_instance_location{};
+  const bool orphan{};
+  const std::optional<sourcemeta::core::Pointer> parent{};
 };
 
 auto repopulate_instance_locations(

src/core/jsonschema/include/sourcemeta/core/jsonschema_resolver.h

@@ -66,7 +66,7 @@ class SOURCEMETA_CORE_JSONSCHEMA_EXPORT SchemaMapResolver {
 #if defined(_MSC_VER)
 #pragma warning(disable : 4251)
 #endif
-  std::map<std::string, JSON> schemas;
+  std::map<std::string, JSON> schemas{};
   SchemaResolver default_resolver = nullptr;
 #if defined(_MSC_VER)
 #pragma warning(default : 4251)

src/core/jsonschema/include/sourcemeta/core/jsonschema_transform.h

@@ -122,8 +122,8 @@ class SOURCEMETA_CORE_JSONSCHEMA_EXPORT SchemaTransformRule {
 #if defined(_MSC_VER)
 #pragma warning(disable : 4251)
 #endif
-  const std::string name_;
-  const std::string message_;
+  const std::string name_{};
+  const std::string message_{};
 #if defined(_MSC_VER)
 #pragma warning(default : 4251)
 #endif

src/core/jsonschema/include/sourcemeta/core/jsonschema_walker.h

@@ -77,7 +77,7 @@ class SOURCEMETA_CORE_JSONSCHEMA_EXPORT SchemaIterator {
 #if defined(_MSC_VER)
 #pragma warning(disable : 4251)
 #endif
-  internal subschemas;
+  internal subschemas{};
 #if defined(_MSC_VER)
 #pragma warning(default : 4251)
 #endif
@@ -144,7 +144,7 @@ class SOURCEMETA_CORE_JSONSCHEMA_EXPORT SchemaIteratorFlat {
 #if defined(_MSC_VER)
 #pragma warning(disable : 4251)
 #endif
-  internal subschemas;
+  internal subschemas{};
 #if defined(_MSC_VER)
 #pragma warning(default : 4251)
 #endif
@@ -201,7 +201,7 @@ class SOURCEMETA_CORE_JSONSCHEMA_EXPORT SchemaKeywordIterator {
 #if defined(_MSC_VER)
 #pragma warning(disable : 4251)
 #endif
-  internal entries;
+  internal entries{};
 #if defined(_MSC_VER)
 #pragma warning(default : 4251)
 #endif

src/core/uri/include/sourcemeta/core/uri.h

@@ -462,20 +462,20 @@ class SOURCEMETA_CORE_URI_EXPORT URI {
 #if defined(_MSC_VER)
 #pragma warning(disable : 4251)
 #endif
-  std::string data;
-
-  std::optional<std::string> path_;
-  std::optional<std::string> userinfo_;
-  std::optional<std::string> host_;
-  std::optional<std::uint32_t> port_;
-  std::optional<std::string> scheme_;
-  std::optional<std::string> fragment_;
-  std::optional<std::string> query_;
+  std::string data{};
+
+  std::optional<std::string> path_{};
+  std::optional<std::string> userinfo_{};
+  std::optional<std::string> host_{};
+  std::optional<std::uint32_t> port_{};
+  std::optional<std::string> scheme_{};
+  std::optional<std::string> fragment_{};
+  std::optional<std::string> query_{};
   bool is_ipv6_ = false;
 
   // Use PIMPL idiom to hide `uriparser`
   struct Internal;
-  std::unique_ptr<Internal> internal;
+  std::unique_ptr<Internal> internal{};
 #if defined(_MSC_VER)
 #pragma warning(default : 4251)
 #endif

src/core/uri/uri.cc

@@ -139,16 +139,11 @@ URI::~URI() { uriFreeUriMembersA(&this->internal->uri); }
 URI::URI(const URI &other) : URI{other.recompose()} {}
 
 URI::URI(URI &&other)
-    : data{std::move(other.data)}, internal{std::move(other.internal)} {
-  this->parsed = other.parsed;
-  this->path_ = std::move(other.path_);
-  this->scheme_ = std::move(other.scheme_);
-  this->userinfo_ = std::move(other.userinfo_);
-  this->host_ = std::move(other.host_);
-  this->port_ = other.port_;
-  this->fragment_ = std::move(other.fragment_);
-  this->query_ = std::move(other.query_);
-
+    : parsed{other.parsed}, data{std::move(other.data)},
+      path_{std::move(other.path_)}, userinfo_{std::move(other.userinfo_)},
+      host_{std::move(other.host_)}, port_{other.port_},
+      scheme_{std::move(other.scheme_)}, fragment_{std::move(other.fragment_)},
+      query_{std::move(other.query_)}, internal{std::move(other.internal)} {
   other.internal = nullptr;
 }