Fix JSONFileParseError to return a const reference of the path (sourcemeta#1742)

jviotti · web-flow · commit 3e7c83ed9261 · 2025-06-20T12:49:21.000-04:00
Fixes: sourcemeta#1741 Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
diff --git a/src/core/json/include/sourcemeta/core/json_error.h b/src/core/json/include/sourcemeta/core/json_error.h
@@ -82,7 +82,7 @@ class SOURCEMETA_CORE_JSON_EXPORT JSONFileParseError : public JSONParseError {
         path_{path} {}
 
   /// Get the file path of the error
-  [[nodiscard]] auto path() const noexcept -> const std::filesystem::path {
+  [[nodiscard]] auto path() const noexcept -> const std::filesystem::path & {
     return path_;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ class SOURCEMETA_CORE_JSON_EXPORT JSONFileParseError : public JSONParseError {`
`82`	`82`	`path_{path} {}`
`83`	`83`
`84`	`84`	`/// Get the file path of the error`
`85`		`- [[nodiscard]] auto path() const noexcept -> const std::filesystem::path {`
	`85`	`+ [[nodiscard]] auto path() const noexcept -> const std::filesystem::path & {`
`86`	`86`	`return path_;`
`87`	`87`	`}`
`88`	`88`