fix: Test for varable existance properly works

Author: hyperupcall

pkg/lib/traverse-set.sh

@@ -51,7 +51,7 @@ bash_object.traverse-set() {
 				if [ "$final_value_type" = object ]; then
 					# TODO: test this
 					# shellcheck disable=SC1087
-					if bash_object.ensure.variable_does_exist "$final_value[@]"; then :; else
+					if bash_object.ensure.variable_does_exist "$final_value"; then :; else
 						return
 					fi
 
@@ -85,7 +85,7 @@ bash_object.traverse-set() {
 				elif [ "$final_value_type" = array ]; then
 					# TODO: test this
 					# shellcheck disable=SC1087
-					if bash_object.ensure.variable_does_exist "$final_value[@]"; then :; else
+					if bash_object.ensure.variable_does_exist "$final_value"; then :; else
 						return
 					fi
 

pkg/lib/util/ensure.sh

@@ -5,7 +5,7 @@ bash_object.ensure.variable_is_valid() {
 	return 0
 }
 
-# @description Ensure the variable already exists. Note that the variable _must_ be sanitized before using this function
+# @description Ensure the variable already exists
 bash_object.ensure.variable_does_exist() {
 	local variable_name="$1"
 
@@ -14,14 +14,9 @@ bash_object.ensure.variable_does_exist() {
 		return
 	fi
 
-	if ((BASH_VERSINFO[0] >= 5)) || ((BASH_VERSINFO[0] == 4 && BASH_VERSINFO[1] >= 2)); then
-		if [[ ! -v "$variable_name" ]]; then
-			bash_object.util.die 'ERROR_INTERNAL_MISCELLANEOUS' "Variable '$variable_name' does not exist, but it should"
+	if ! declare -p "$variable_name" &>/dev/null; then
+		bash_object.util.die 'ERROR_INTERNAL_MISCELLANEOUS' "Variable '$variable_name' does not exist, but it should"
 			return
-		fi
-	else
-		# TODO
-		:
 	fi
 }