fix: Error on unimplemented flags

Author: hyperupcall

pkg/lib/traverse-get.sh

@@ -39,6 +39,10 @@ bash_object.traverse-get() {
 		return
 	fi
 
+	if [ "$flag_as_what" = 'as-ref' ]; then
+		bash_object.util.die 'ERROR_ARGUMENTS_INVALID' "--as-ref not implemented"
+	fi
+
 	# Ensure correct number of arguments have been passed
 	if (( ${#args[@]} != 3)); then
 		bash_object.util.die 'ERROR_ARGUMENTS_INVALID' "Expected '3' arguments, but received '${#args[@]}'"

pkg/lib/traverse-set.sh

@@ -37,6 +37,10 @@ bash_object.traverse-set() {
 		return
 	fi
 
+	if [ "$flag_pass_by_what" = 'by-value' ]; then
+		bash_object.util.die 'ERROR_ARGUMENTS_INVALID' "--by-value not implemented"
+	fi
+
 	local final_value_type root_object_name filter final_value
 	# `set -u` compat
 	if [ -n "${args[0]+x}" ]; then

tests/errors-required-flags.bats

@@ -19,6 +19,14 @@ load './util/init.sh'
 	assert_line -p "Flags '--as-ref' and '--as-value' are mutually exclusive"
 }
 
+@test "error on unimplemented --as-ref" {
+	run bobject get-string --as-ref
+
+	assert_failure
+	assert_line -p 'ERROR_ARGUMENTS_INVALID'
+	assert_line -p "--as-ref not implemented"
+}
+
 # set
 @test "set errors on missing flags" {
 	run bobject set-string
@@ -35,3 +43,11 @@ load './util/init.sh'
 	assert_line -p 'ERROR_ARGUMENTS_INVALID'
 	assert_line -p "Flags '--by-ref' and '--by-value' are mutually exclusive"
 }
+
+@test "error on unimplemented --by-value" {
+	run bobject set-string --by-value
+
+	assert_failure
+	assert_line -p 'ERROR_ARGUMENTS_INVALID'
+	assert_line -p "--by-value not implemented"
+}