fix: set-object now works in the basic case

Author: hyperupcall

pkg/lib/traverse-get.sh

@@ -108,6 +108,8 @@ bash_object.traverse-get() {
 							return
 							;;
 						array)
+							declare -ga REPLY=()
+							# shellcheck disable=SC2190
 							REPLY=("${current_object[@]}")
 							;;
 						*)
@@ -155,6 +157,7 @@ bash_object.traverse-get() {
 						bash_object.util.traverse_fail 'ERROR_VALUE_INCORRECT_TYPE' "Queried for array, but found string '$value'"
 						return
 					elif [ "$final_value_type" = string ]; then
+						# shellcheck disable=SC2178
 						REPLY="$value"
 					fi
 				fi

pkg/lib/traverse-set.sh

@@ -64,6 +64,7 @@ bash_object.traverse-set() {
 
 					# 1. Create object
 					if ! eval "declare -gA $new_current_object_name=()"; then
+						# TODO: error
 						printf '%s\n' 'Error: bash-object: eval declare failed'
 						return 1
 					fi
@@ -73,7 +74,8 @@ bash_object.traverse-set() {
 
 					local -n new_current_object="$new_current_object_name"
 					local -n object_to_copy="$final_value"
-					for key in "${!new_current_object[@]}"; do
+					# test if the object_to_copy is of the right type
+					for key in "${!object_to_copy[@]}"; do
 						new_current_object["$key"]="${object_to_copy["$key"]}"
 					done
 				elif [ "$final_value_type" = array ]; then

tests/set-object.bats

@@ -3,17 +3,17 @@
 load './util/init.sh'
 
 @test "correctly sets object" {
-	declare -a obj=([omicron]=pi rho=sigma tau=upsilon)
+	declare -A obj=([omicron]=pi [rho]=sigma [tau]=upsilon)
 	declare -A OBJECT=()
 
-	bash_object.traverse-set object OBJECT '.obj' obj
+	bash_object.traverse-set object 'OBJECT' '.obj' obj
 
-	bash_object.traverse-get object OBJECT '.obj'
-	assert [ ${#REPLY} -eq 3 ]
+	bash_object.traverse-get object 'OBJECT' '.obj'
+	assert [ ${#REPLY[@]} -eq 3 ]
 	assert [ "${REPLY[omicron]}" = pi ]
 	assert [ "${REPLY[rho]}" = sigma ]
 	assert [ "${REPLY[tau]}" = upsilon ]
 
-	bash_object.traverse-get string OBJECT '.obj.rho'
+	bash_object.traverse-get string 'OBJECT' '.obj.rho'
 	assert [ "$REPLY" = sigma ]
 }

tests/set-string.bats

@@ -63,14 +63,21 @@ load './util/init.sh'
 	declare -A OBJECT=([omicron]=$'\x1C\x1Dtype=object;&SUB_OBJECT')
 
 	bash_object.traverse-set string 'OBJECT' '.omicron.pi.rho' 'sigma'
-
 	bash_object.traverse-get string 'OBJECT' '.omicron.pi.rho'
 	assert [ "$REPLY" = 'sigma' ]
-
-	bash_object.traverse-get object 'OBJECT' '.omicron.pi'
-	assert [ "${REPLY[rho]}" = 'sigma' ]
 }
 
+# @test "correctly sets string in subobject 2" {
+# 	declare -A OBJECT=()
+
+# 	bash_object.traverse-set object 'OBJECT' '.omicron'
+# 	bash_object.traverse-set object 'OBJECT' '.omicron.pi'
+
+# 	bash_object.traverse-set string 'OBJECT' '.omicron.pi.rho' 'sigma'
+# 	bash_object.traverse-get string 'OBJECT' '.omicron.pi.rho'
+# 	assert [ "$REPLY" = 'sigma' ]
+# }
+
 @test "correctly sets 2 strings in subobject" {
 	declare -A SUB_SUB_OBJECT=()
 	declare -A SUB_OBJECT=([pi]=$'\x1C\x1Dtype=object;&SUB_SUB_OBJECT')