fix: Errors properly return instead of exit

Author: hyperupcall

pkg/bin/bobject

@@ -54,7 +54,7 @@ elif [ -d "$REPLY/lib" ]; then
 	BASH_OBJECT_LIB_DIR="$REPLY/lib"
 else
 	echo "Error: Could not determine \$BASH_OBJECT_LIB_DIR"
-	exit 1
+	return 1
 fi
 
 # shellcheck disable=SC1091

pkg/lib/cmd/bobject.sh

@@ -12,53 +12,53 @@ bobject() {
 		get-string)
 			if (($# != 2)); then
 				printf '%s\n' "bash-object: Error: Incorrect arguments for subcommand '$subcmd'"
-				exit 1
+				return 1
 			fi
 
 			bash_object.traverse-get string "$@"
 			;;
 		get-array)
 			if (($# != 2)); then
 				printf '%s\n' "bash-object: Error: Incorrect arguments for subcommand '$subcmd'"
-				exit 1
+				return 1
 			fi
 
 			bash_object.traverse-get array "$@"
 			;;
 		get-object)
 			if (($# != 2)); then
 				printf '%s\n' "bash-object: Error: Incorrect arguments for subcommand '$subcmd'"
-				exit 1
+				return 1
 			fi
 
 			bash_object.traverse-get object "$@"
 			;;
 		set-string)
 			if (($# != 3)); then
 				printf '%s\n' "bash-object: Error: Incorrect arguments for subcommand '$subcmd'"
-				exit 1
+				return 1
 			fi
 
 			bash_object.traverse-set string "$@"
 			;;
 		set-array)
 			if (($# != 3)); then
 				printf '%s\n' "bash-object: Error: Incorrect arguments for subcommand '$subcmd'"
-				exit 1
+				return 1
 			fi
 
 			bash_object.traverse-set array "$@"
 			;;
 		set-object)
 			if (($# != 3)); then
 				printf '%s\n' "bash-object: Error: Incorrect arguments for subcommand '$subcmd'"
-				exit 1
+				return 1
 			fi
 
 			bash_object.traverse-set object "$@"
 			;;
 		*)
 			printf '%s\n' "bash-object: Error: Subcommand '$subcmd' not recognized"
-			exit 1
+			return 1
 	esac
 }

pkg/lib/traverse-get.sh

@@ -40,7 +40,7 @@ bash_object.traverse-get() {
 		# If 'key' is not a member of object or index of array, error
 		if [ -z "${current_object["$key"]+x}" ]; then
 			echo "Error: Key '$key' is not in object '$current_object_name'"
-			exit 1
+			return 1
 		else
 		# If 'key' is a member of an object, or index of array
 			if [ -n "${TRACE_BASH_OBJECT_TRAVERSE+x}" ]; then
@@ -145,7 +145,7 @@ bash_object.traverse-get() {
 				if ((i+1 < ${#REPLIES[@]})); then
 					# TODO
 					echo "mu" >&3
-					exit 2
+					# return 2
 					:
 				elif ((i+1 == ${#REPLIES[@]})); then
 					local value="${current_object["$key"]}"

pkg/lib/traverse-set.sh

@@ -42,7 +42,7 @@ bash_object.traverse-set() {
 				# TODO: double-check if new_current_object_name only has underscores, dots, etc. (printf %q?)
 				if ! eval "declare -gA $new_current_object_name=()"; then
 					printf '%s\n' 'Error: bash-object: eval declare failed'
-					exit 1
+					return 1
 				fi
 
 				current_object["$key"]=$'\x1C\x1D'"type=object;&$new_current_object_name"
@@ -80,7 +80,7 @@ bash_object.traverse-set() {
 				else
 					# TODO: throw error
 					echo "phi" >&3
-					exit 1
+					# return 1
 				fi
 				:
 			elif ((i+1 == ${#REPLIES[@]})); then
@@ -115,19 +115,19 @@ bash_object.traverse-set() {
 						object)
 							# TODO: test this
 							echo "Error: Cannot set string on object"
-							exit 1
+							return 1
 							;;
 						array)
 							echo "Error: Cannot set string on array"
-							exit 1
+							return 1
 							;;
 						esac
 					fi
 					current_object["$key"]="$final_value"
 				else
 					# TODO: throw error
 					echo "omicron" >&3
-					exit 1
+					return 1
 				fi
 			fi
 		fi