feat: Error if ref is given when uninstalling or upgrading package

Ref is not required since there can only be one version of any
particular package at any point in time. This reduces confusion due to
the extraneous disambiguation

Author: hyperupcall

pkg/lib/commands/do-remove.sh

@@ -48,6 +48,11 @@ do-remove() {
 		util.extract_data_from_input "$repoSpec"
 		local site="$REPLY2"
 		local package="$REPLY3"
+		local ref="$REPLY4"
+
+		if [ -n "$ref" ]; then
+			die "Refs must be omitted when upgrading packages. Remove ref '@$ref'"
+		fi
 
 		if [ -d "$BPM_PACKAGES_PATH/$site/$package" ]; then
 			do_actual_removal "$site/$package"

pkg/lib/commands/do-upgrade.sh

@@ -42,6 +42,11 @@ do-upgrade() {
 		util.extract_data_from_input "$repoSpec"
 		local site="$REPLY2"
 		local package="$REPLY3"
+		local ref="$REPLY4"
+
+		if [ -n "$ref" ]; then
+			die "Refs must be omitted when upgrading packages. Remove ref '@$ref'"
+		fi
 
 		if [ -L "$BPM_PACKAGES_PATH/$site/$package" ]; then
 			die "Package '$site/$package' is locally symlinked and cannot be upgraded through Git"

tests/do-remove.bats

@@ -182,3 +182,17 @@ load 'util/init.sh'
 	assert_failure
 	assert_line -p "No packages may be supplied when using '--all'"
 }
+
+
+@test "fail if ref is given during remove" {
+	local site='github.com'
+	local pkg='username/package'
+
+	test_util.create_package "$pkg"
+	test_util.mock_clone "$pkg" "$site/$pkg"
+
+	run do-upgrade "$pkg@v0.1.0"
+
+	assert_failure
+	assert_line -p "Refs must be omitted when upgrading packages. Remove ref '@v0.1.0'"
+}

tests/do-upgrade.bats

@@ -168,3 +168,16 @@ load 'util/init.sh'
 	assert_failure
 	assert_line -p 'Packages cannot be upgraded at the same time as bpm'
 }
+
+@test "fail if ref is given during upgrade" {
+	local site='github.com'
+	local pkg='username/package'
+
+	test_util.create_package "$pkg"
+	test_util.mock_clone "$pkg" "$site/$pkg"
+
+	run do-upgrade "$pkg@v0.1.0"
+
+	assert_failure
+	assert_line -p "Refs must be omitted when upgrading packages. Remove ref '@v0.1.0'"
+}