fix: Remove check before 'unlink'. Closes #61

The check was originally implemented because it was required for
'abstract-mans' (and copied to the other abstract-*.sh files). This is
because the heuristics for the man linking implemented the same
search functionality for the root directory and the 'man' subdirectory,
which caused files to be detected twice. On the second unlink, a failure
occured. Since that code no longer exists, the check is no longer needed

Author: hyperupcall

pkg/lib/util/abstract-bins.sh

@@ -127,8 +127,8 @@ abstract.bins_do_action() {
 			fi
 			;;
 		unlink)
-			if [ -f "$BPM_INSTALL_BIN/$binName" ]; then
-				unlink "$BPM_INSTALL_BIN/$binName"
+			if ! unlink "$BPM_INSTALL_BIN/$binName"; then
+				die "Unlink failed, but was expected to succeed"
 			fi
 			;;
 	esac

pkg/lib/util/abstract-completions.sh

@@ -142,8 +142,8 @@ abstract.completions_do_action_bash() {
 		fi
 		;;
 	unlink)
-		if [ -f "$BPM_INSTALL_COMPLETIONS/bash/$fileName" ]; then
-			unlink "$BPM_INSTALL_COMPLETIONS/bash/$fileName"
+		if ! unlink "$BPM_INSTALL_COMPLETIONS/bash/$fileName"; then
+			die "Unlink failed, but was expected to succeed"
 		fi
 		;;
 	esac
@@ -165,15 +165,16 @@ abstract.completions_do_action_zsh() {
 		case "$action" in
 				link)
 			if [ -L "$BPM_INSTALL_COMPLETIONS/zsh/compsys/$fileName" ]; then
+				# TODO: ?
 				log.error "Skipping '$fileName' since an existing symlink with the same name already exists"
 			else
 				mkdir -p "$BPM_INSTALL_COMPLETIONS/zsh/compsys"
 				ln -sf "$file" "$BPM_INSTALL_COMPLETIONS/zsh/compsys/$fileName"
 			fi
 			;;
 		unlink)
-			if [ -f "$BPM_INSTALL_COMPLETIONS/zsh/compsys/$fileName" ]; then
-				unlink "$BPM_INSTALL_COMPLETIONS/zsh/compsys/$fileName"
+			if ! unlink "$BPM_INSTALL_COMPLETIONS/zsh/compsys/$fileName"; then
+				die "Unlink failed, but was expected to succeed"
 			fi
 			;;
 		esac
@@ -188,8 +189,8 @@ abstract.completions_do_action_zsh() {
 			fi
 			;;
 		unlink)
-			if [ -f "$BPM_INSTALL_COMPLETIONS/zsh/compctl/${file##*/}" ]; then
-				unlink "$BPM_INSTALL_COMPLETIONS/zsh/compctl/${file##*/}"
+			if ! unlink "$BPM_INSTALL_COMPLETIONS/zsh/compctl/${file##*/}"; then
+				die "Unlink failed, but was expected to succeed"
 			fi
 			;;
 		esac
@@ -212,8 +213,8 @@ abstract.completions_do_action_fish() {
 		fi
 		;;
 	unlink)
-		if [ -f "$BPM_INSTALL_COMPLETIONS/fish/${file##*/}" ]; then
-			unlink "$BPM_INSTALL_COMPLETIONS/fish/${file##*/}"
+		if ! unlink "$BPM_INSTALL_COMPLETIONS/fish/${file##*/}"; then
+			die "Unlink failed, but was expected to succeed"
 		fi
 		;;
 	esac

pkg/lib/util/abstract-mans.sh

@@ -104,11 +104,8 @@ abstract.mans_do_action() {
 				fi
 				;;
 			unlink)
-				# Because 'abstract.mans_search_heuristics' sometimes repeats
-				# directories, and sometimes the stat's are out of dates, we add this
-				# check in case a file was deleted in the meantime
-				if [ -f "$BPM_INSTALL_MAN/man$n/$manFile" ]; then
-					unlink "$BPM_INSTALL_MAN/man$n/$manFile"
+				if ! unlink "$BPM_INSTALL_MAN/man$n/$manFile"; then
+					die "Unlink failed, but was expected to succeed"
 				fi
 				;;
 		esac