fix: Error output

Author: hyperupcall

README.md

@@ -38,7 +38,7 @@ See [Installation](./docs/installation.md) and [Getting Started](./docs/getting-
 - Local and user-wide package installation
 - Configure (optionally) exactly which directories are used for completions, binaries, or man pages
 - Works with essentially all popular Bash projects out of the box
-- 220+ Tests
+- 240+ Tests
 
 ## Alternatives Comparison
 

pkg/lib/commands/do-remove.sh

@@ -51,7 +51,7 @@ do-remove() {
 		local ref="$REPLY4"
 
 		if [ -n "$ref" ]; then
-			die "Refs must be omitted when upgrading packages. Remove ref '@$ref'"
+			die "Refs must be omitted when removing packages. Remove ref '@$ref'"
 		fi
 
 		if [ -d "$BPM_PACKAGES_PATH/$site/$package" ]; then

pkg/lib/util/util.sh

@@ -79,7 +79,7 @@ util.extract_data_from_input() {
 			site="github.com"
 			package="$repoSpec"
 		else
-			die "Invalid repository '$repoSpec'"
+			die "Package '$repoSpec' does not appear to be formatted correctly"
 		fi
 
 		if [[ "$package" == *@* ]]; then

tests/do-add.bats

@@ -28,6 +28,7 @@ load 'util/init.sh'
 	assert_line -n 0 -p  "Cannot install packages owned by username 'local' because that conflicts with linked packages"
 }
 
+# TODO: do for link
 @test "fails when input is an absolute path to a directory" {
 	local site='github.com'
 	local pkg='username/main'

tests/do-remove.bats

@@ -194,5 +194,5 @@ load 'util/init.sh'
 	run do-upgrade "$pkg@v0.1.0"
 
 	assert_failure
-	assert_line -p "Refs must be omitted when upgrading packages. Remove ref '@v0.1.0'"
+	assert_line -p "Refs must be omitted when removing packages. Remove ref '@v0.1.0'"
 }

tests/util-extract-data-from-input.bats

@@ -166,3 +166,10 @@ load 'util/init.sh'
 	assert_failure
 	assert_line -p "Directory specified with file protocol must have at least one parent directory"
 }
+
+@test "errors with friendly message if format is not proper" {
+	run util.extract_data_from_input 'UwU'
+
+	assert_failure
+	assert_line -p "Package 'UwU' does not appear to be formatted correctly"
+}