Skip to content

Commit dd64bb6

Browse files
committed
refactor: Quote '$ref' to allow for more argument passing
1 parent ccf9c81 commit dd64bb6

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

pkg/lib/commands/do-add.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ do-add() {
6161
fi
6262

6363
log.info "Adding '$repoSpec'"
64-
do-plumbing-clone "$uri" "$site/$package" $ref
64+
do-plumbing-clone "$uri" "$site/$package" "$ref"
6565
do-plumbing-add-deps "$site/$package"
6666
do-plumbing-link-bins "$site/$package"
6767
do-plumbing-link-completions "$site/$package"

tests/do-add.bats

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ load 'util/init.sh'
5656

5757
assert_success
5858
assert_line -n 0 -p "Adding 'username/package'"
59-
assert_line -n 1 'do-plumbing-clone https://github.com/username/package.git github.com/username/package'
59+
assert_line -n 1 'do-plumbing-clone https://github.com/username/package.git github.com/username/package '
6060
assert_line -n 2 'do-plumbing-add-deps github.com/username/package'
6161
assert_line -n 3 'do-plumbing-link-bins github.com/username/package'
6262
assert_line -n 4 'do-plumbing-link-completions github.com/username/package'
@@ -74,13 +74,13 @@ load 'util/init.sh'
7474

7575
assert_success
7676
assert_line -n 0 -p "Adding 'username/package'"
77-
assert_line -n 1 'do-plumbing-clone https://github.com/username/package.git github.com/username/package'
77+
assert_line -n 1 'do-plumbing-clone https://github.com/username/package.git github.com/username/package '
7878
assert_line -n 2 'do-plumbing-add-deps github.com/username/package'
7979
assert_line -n 3 'do-plumbing-link-bins github.com/username/package'
8080
assert_line -n 4 'do-plumbing-link-completions github.com/username/package'
8181
assert_line -n 5 'do-plumbing-link-man github.com/username/package'
8282
assert_line -n 6 -p "Adding 'username2/package2'"
83-
assert_line -n 7 'do-plumbing-clone https://github.com/username2/package2.git github.com/username2/package2'
83+
assert_line -n 7 'do-plumbing-clone https://github.com/username2/package2.git github.com/username2/package2 '
8484
assert_line -n 8 'do-plumbing-add-deps github.com/username2/package2'
8585
assert_line -n 9 'do-plumbing-link-bins github.com/username2/package2'
8686
assert_line -n 10 'do-plumbing-link-completions github.com/username2/package2'
@@ -98,7 +98,7 @@ load 'util/init.sh'
9898
run do-add https://gitlab.com/username/package
9999

100100
assert_success
101-
assert_line "do-plumbing-clone https://gitlab.com/username/package.git gitlab.com/username/package"
101+
assert_line "do-plumbing-clone https://gitlab.com/username/package.git gitlab.com/username/package "
102102
}
103103

104104
@test "uses longhand (http) site to clone from, if specified" {
@@ -111,7 +111,7 @@ load 'util/init.sh'
111111
run do-add http://gitlab.com/username/package
112112

113113
assert_success
114-
assert_line "do-plumbing-clone http://gitlab.com/username/package.git gitlab.com/username/package"
114+
assert_line "do-plumbing-clone http://gitlab.com/username/package.git gitlab.com/username/package "
115115
}
116116

117117
@test "uses shorthand site to clone from, if specified" {
@@ -124,7 +124,7 @@ load 'util/init.sh'
124124
run do-add site/username/package
125125

126126
assert_success
127-
assert_line "do-plumbing-clone https://site/username/package.git site/username/package"
127+
assert_line "do-plumbing-clone https://site/username/package.git site/username/package "
128128
}
129129

130130
@test "uses GitHub as default site, if not specified" {
@@ -137,7 +137,7 @@ load 'util/init.sh'
137137
run do-add username/package
138138

139139
assert_success
140-
assert_line "do-plumbing-clone https://github.com/username/package.git github.com/username/package"
140+
assert_line "do-plumbing-clone https://github.com/username/package.git github.com/username/package "
141141
}
142142

143143
@test "uses ssh protocol, when specified" {
@@ -150,7 +150,7 @@ load 'util/init.sh'
150150
run do-add --ssh username/package
151151

152152
assert_success
153-
assert_line "do-plumbing-clone git@github.com:username/package github.com/username/package"
153+
assert_line "do-plumbing-clone git@github.com:username/package github.com/username/package "
154154
}
155155

156156
@test "uses ssh protocol, when specified (at end)" {
@@ -163,7 +163,7 @@ load 'util/init.sh'
163163
run do-add username/package --ssh
164164

165165
assert_success
166-
assert_line "do-plumbing-clone git@github.com:username/package github.com/username/package"
166+
assert_line "do-plumbing-clone git@github.com:username/package github.com/username/package "
167167
}
168168

169169
@test "uses ssh protocol raw, when specified" {
@@ -176,7 +176,7 @@ load 'util/init.sh'
176176
run do-add git@github.com:username/package
177177

178178
assert_success
179-
assert_line "do-plumbing-clone git@github.com:username/package github.com/username/package"
179+
assert_line "do-plumbing-clone git@github.com:username/package github.com/username/package "
180180
}
181181

182182
@test "uses custom version, when specified" {
@@ -202,7 +202,7 @@ load 'util/init.sh'
202202
run do-add username/package@
203203

204204
assert_success
205-
assert_line "do-plumbing-clone https://github.com/username/package.git github.com/username/package"
205+
assert_line "do-plumbing-clone https://github.com/username/package.git github.com/username/package "
206206
}
207207

208208
@test "--all prints warning when no dependencies are specified in bpm.toml" {

0 commit comments

Comments
 (0)