refactor: Add Check to ensure package existance before linking. Closes #28

This increases the integrity of tests that install a package,
then uninstall that package, and test if a file does not exist

Author: hyperupcall

pkg/lib/commands/do-plumbing-deps.sh

@@ -9,6 +9,7 @@
 do-plumbing-deps() {
 	local package="$1"
 	ensure.nonZero 'package' "$package"
+	ensure.packageExists "$package"
 
 	local -a deps=()
 

pkg/lib/commands/do-plumbing-link-bins.sh

@@ -3,6 +3,7 @@
 do-plumbing-link-bins() {
 	local package="$1"
 	ensure.nonZero 'package' "$package"
+	ensure.packageExists "$package"
 
 	log.info "Linking bin files for '$package'"
 

pkg/lib/commands/do-plumbing-link-completions.sh

@@ -3,6 +3,7 @@
 do-plumbing-link-completions() {
 	local package="$1"
 	ensure.nonZero 'package' "$package"
+	ensure.packageExists "$package"
 
 	log.info "Linking completion files for '$package'"
 

pkg/lib/commands/do-plumbing-link-man.sh

@@ -4,6 +4,7 @@
 do-plumbing-link-man() {
 	local package="$1"
 	ensure.nonZero 'package' "$package"
+	ensure.packageExists "$package"
 
 	log.info "Linking man files for '$package'"
 

pkg/lib/util/ensure.sh

@@ -24,3 +24,18 @@ ensure.nonZero() {
 		die "Variable '$varName' must be non-zero. Please check the validity of your passed arguments"
 	fi
 }
+
+# @description This is a check to determine if a package actually exists.
+# If it does not, then the program fails. This was created to increase
+# the integrity of the testing suite. Most of the callsites of this
+# function are in 'do-plumbing-link' since we expect a package to exist
+# before performing operations on it. This contrasts 'do-plumbing-unlink' -
+# that is not an expectation
+# @arg $1 package
+ensure.packageExists() {
+	local package="$1"
+
+	if [ ! -d "$BPM_PACKAGES_PATH/$package" ]; then
+		die "Package '$package' does not exist"
+	fi
+}