refactor: Rename 'BPM_IS_LOCAL' to 'BPM_MODE'

Author: hyperupcall

pkg/lib/cmd/bpm.sh

@@ -15,7 +15,7 @@ main() {
 		source "$f"
 	done
 
-	BPM_IS_LOCAL='yes'
+	BPM_MODE='local'
 
 	for arg; do
 		case "$arg" in
@@ -30,7 +30,7 @@ main() {
 			exit
 			;;
 		--global|-g)
-			BPM_IS_LOCAL='no'
+			BPM_MODE='global'
 			shift
 			;;
 		*)

pkg/lib/commands/do-add.sh

@@ -36,11 +36,11 @@ do-add() {
 		die "No packages may be supplied when using '--all'"
 	fi
 
-	if [ "$BPM_IS_LOCAL" = yes ] && (( ${#pkgs[@]} > 0 )); then
+	if [ "$BPM_MODE" = local ] && (( ${#pkgs[@]} > 0 )); then
 		die "Cannot specify individual packages for subcommand 'add' in local projects. Please edit your 'bpm.toml' and use either 'add --all' or 'remove --all'"
 	fi
 
-	if [[ "$BPM_IS_LOCAL" == no && "$flag_all" == yes ]]; then
+	if [[ "$BPM_MODE" == global && "$flag_all" == yes ]]; then
 		die "Cannot pass '--all' without a 'bpm.toml' file"
 	fi
 
@@ -89,7 +89,7 @@ do-actual-add() {
 	fi
 
 	if [ -e "$BPM_PACKAGES_PATH/$site/$package" ]; then
-		if [ "$BPM_IS_LOCAL" = yes ]; then
+		if [ "$BPM_MODE" = local ]; then
 			log.info "Skipping '$site/$package' as it's already present"
 			return
 		else

pkg/lib/commands/do-remove.sh

@@ -28,7 +28,7 @@ do-remove() {
 		die "No packages may be supplied when using '--all'"
 	fi
 
-	if [ "$BPM_IS_LOCAL" = yes ] && (( ${#pkgs[@]} > 0 )); then
+	if [ "$BPM_MODE" = local ] && (( ${#pkgs[@]} > 0 )); then
 		die "Cannot specify individual packages for subcommand 'remove' in local projects. Please edit your 'bpm.toml' and use either 'add --all' or 'remove --all'"
 	fi
 

pkg/lib/commands/do-upgrade.sh

@@ -28,15 +28,15 @@ do-upgrade() {
 		die "No packages may be supplied when using '--all'"
 	fi
 
-	if [ "$BPM_IS_LOCAL" = yes ] && (( ${#pkgs[@]} > 0 )); then
+	if [ "$BPM_MODE" = local ] && (( ${#pkgs[@]} > 0 )); then
 		die "Cannot specify individual packages for subcommand 'upgrade' in local projects. Please edit your 'bpm.toml' and use either 'add --all' or 'remove --all'"
 	fi
 
 	if [[ $upgrade_bpm == yes && "$flag_all" = yes ]]; then
 		die "Upgrading bpm and using '--all' are mutually exclusive behaviors"
 	fi
 
-	if [[ $upgrade_bpm == yes && "$BPM_IS_LOCAL" == yes ]]; then
+	if [[ $upgrade_bpm == yes && "$BPM_MODE" == local ]]; then
 		die "Cannot upgrade bpm with a local 'bpm.toml' file"
 	fi
 

pkg/lib/util/util.sh

@@ -268,7 +268,7 @@ util.get_project_root_dir() {
 
 # @description Sets up the variables for the current mode
 util.setup_mode() {
-	if [ "$BPM_IS_LOCAL" = yes ]; then
+	if [ "$BPM_MODE" = local ]; then
 		local project_root_dir=
 		if project_root_dir="$(util.get_project_root_dir)"; then
 			# Output to standard error because some subcommands may be scriptable (ex. list)

tests/do-add.bats

@@ -215,7 +215,7 @@ load 'util/init.sh'
 	test_util.create_package "$pkg2"
 
 	echo "dependencies = [ 'file://$BPM_ORIGIN_DIR/$pkg', 'file://$BPM_ORIGIN_DIR/$pkg2' ]" > 'bpm.toml'
-	BPM_IS_LOCAL='yes' run do-add --all
+	BPM_MODE='local' run do-add --all
 
 	assert_success
 
@@ -239,7 +239,7 @@ load 'util/init.sh'
 	cd "$BPM_CWD"
 
 	echo "dependencies = [ 'file://$BPM_ORIGIN_DIR/$pkg', 'file://$BPM_ORIGIN_DIR/$pkg2' ]" > 'bpm.toml'
-	BPM_IS_LOCAL='yes' run do-add --all
+	BPM_MODE='local' run do-add --all
 
 	assert_success
 	assert [ -d "./bpm_packages/packages/$site/$pkg/.git" ]
@@ -258,7 +258,7 @@ load 'util/init.sh'
 	cd "$BPM_CWD"
 
 	echo "dependencies = [ 'file://$BPM_ORIGIN_DIR/$pkg1@v0.1.0' ]" > 'bpm.toml'
-	BPM_IS_LOCAL='yes' run do-add --all
+	BPM_MODE='local' run do-add --all
 
 	assert_success
 	assert [ -d "./bpm_packages/packages/$site/$pkg1" ]
@@ -277,7 +277,7 @@ load 'util/init.sh'
 	cd "$BPM_CWD"
 
 	echo "dependencies = [ 'file://$BPM_ORIGIN_DIR/$pkg1@v0.1.0' ]" > 'bpm.toml'
-	BPM_IS_LOCAL='yes' run do-add --all
+	BPM_MODE='local' run do-add --all
 
 	assert_success
 	assert [ -d "./bpm_packages/packages/$site/$pkg1" ]
@@ -288,7 +288,7 @@ load 'util/init.sh'
 @test "--all prints warning when no dependencies are specified in bpm.toml" {
 	touch 'bpm.toml'
 
-	BPM_IS_LOCAL='yes' run do-add --all
+	BPM_MODE='local' run do-add --all
 
 	assert_success
 	assert_line -p "No dependencies specified in 'dependencies' key"
@@ -298,7 +298,7 @@ load 'util/init.sh'
 @test "--all errors when a package is specified as argument" {
 	touch 'bpm.toml'
 
-	BPM_IS_LOCAL='yes' run do-add --all pkg
+	BPM_MODE='local' run do-add --all pkg
 
 	assert_failure
 	assert_line -p "No packages may be supplied when using '--all'"
@@ -320,12 +320,12 @@ load 'util/init.sh'
 	test_util.create_package "$pkg2"
 
 	echo "dependencies = [ 'file://$BPM_ORIGIN_DIR/$pkg1' ]" > 'bpm.toml'
-	BPM_IS_LOCAL='yes' run do-add --all
+	BPM_MODE='local' run do-add --all
 
 	assert_success
 
 	echo "dependencies = [ 'file://$BPM_ORIGIN_DIR/$pkg1', 'file://$BPM_ORIGIN_DIR/$pkg2' ]" > 'bpm.toml'
-	BPM_IS_LOCAL='yes' run do-add --all
+	BPM_MODE='local' run do-add --all
 
 	assert_success
 	assert [ -d "./bpm_packages/packages/$site/$pkg1" ]
@@ -342,7 +342,7 @@ load 'util/init.sh'
 
 	test_util.create_package "$pkg1"
 
-	BPM_IS_LOCAL='yes' run do-add "$pkg1"
+	BPM_MODE='local' run do-add "$pkg1"
 
 	assert_failure
 	assert_line -p "Cannot specify individual packages for subcommand 'add' in local projects. Please edit your 'bpm.toml' and use either 'add --all' or 'remove --all'"

tests/do-remove.bats

@@ -252,7 +252,7 @@ load 'util/init.sh'
 
 	test_util.create_package "$pkg1"
 
-	BPM_IS_LOCAL='yes' run do-remove "$pkg1"
+	BPM_MODE='local' run do-remove "$pkg1"
 
 	assert_failure
 	assert_line -p "Cannot specify individual packages for subcommand 'remove' in local projects. Please edit your 'bpm.toml' and use either 'add --all' or 'remove --all'"

tests/do-upgrade.bats

@@ -193,7 +193,7 @@ load 'util/init.sh'
 @test "fail if bpm is specified in local mode" {
 	touch 'bpm.toml'
 
-	BPM_IS_LOCAL='yes' run do-upgrade bpm
+	BPM_MODE='local' run do-upgrade bpm
 
 	assert_failure
 	assert_line -p "Cannot upgrade bpm with a local 'bpm.toml' file"
@@ -216,7 +216,7 @@ load 'util/init.sh'
 
 	test_util.create_package "$pkg1"
 
-	BPM_IS_LOCAL='yes' run do-upgrade "$pkg1"
+	BPM_MODE='local' run do-upgrade "$pkg1"
 
 	assert_failure
 	assert_line -p "Cannot specify individual packages for subcommand 'upgrade' in local projects. Please edit your 'bpm.toml' and use either 'add --all' or 'remove --all'"

tests/util/init.sh

@@ -17,7 +17,7 @@ export BPM_TEST_DIR="$BATS_TMPDIR/bpm"
 export BPM_CWD="$BPM_TEST_DIR/cwd"
 export BPM_ORIGIN_DIR="$BPM_TEST_DIR/origin"
 export BPM_MODE_TEST=
-export BPM_IS_LOCAL='no' # normal default is 'yes'
+export BPM_MODE='global' # normal default is 'local'
 
 # Stub common variables
 test_util.get_bpm_root