test: Fail list if a package is not a Git repository

Author: hyperupcall

pkg/lib/commands/do-list.sh

@@ -57,7 +57,9 @@ do-list() {
 			printf -v pkg_output "%s\n" "$id"
 
 			if [ "$flag_simple" = 'no' ]; then
-				ensure.git_repository "$pkg_path" "$id"
+				if [ ! -d "$pkg_path/.git" ]; then
+					die "Package '$id' is not a Git repository. Unlink or otherwise remove it at '$pkg_path'"
+				fi
 
 				local repo_branch_str= repo_outdated_str=
 

pkg/lib/util/ensure.sh

@@ -39,12 +39,3 @@ ensure.package_exists() {
 		die "Package '$package' does not exist"
 	fi
 }
-
-ensure.git_repository() {
-	local dir="$1"
-	local id="$2"
-
-	if [ ! -d "$dir/.git" ]; then
-		die "Package '$id' is not a Git repository. Unlink or otherwise remove it at '$dir'"
-	fi
-}

tests/do-list.bats

@@ -86,26 +86,14 @@ $site/username/p1
   Branch: master"
 }
 
-@test "properly list outdated packages" {
+@test "error if tries to list a non-git repository with details" {
 	local site="github.com"
-	local pkg1='username/outdated'
-	local pkg2='username/uptodate'
+	local pkg='username/outdated'
 
-	test_util.create_package "$pkg1"
-	test_util.create_package "$pkg2"
-	test_util.fake_clone "$site/$pkg1"
-	test_util.fake_clone "$site/$pkg2"
+	mkdir -p "$BPM_PACKAGES_PATH/$site/$pkg"
 
-	# Make pkg1 outdated by commiting to it
-	cd "$BPM_ORIGIN_DIR/$site/$pkg1"; {
-		mkdir -p bin
-		touch "bin/exec"
-		git add .
-		git commit -m "Add exec"
-	}; cd "$BPM_CWD"
-
-	run do-list --outdated
+	run do-list
 
-	assert_success
-	assert_output 'github.com/username/outdated'
+	assert_failure
+	assert_line -n 0 -p "Package '$site/$pkg' is not a Git repository. Unlink or"
 }