feat: Print to user when linking deps,bins,completion,man etc. Closes #25

Author: hyperupcall

pkg/lib/commands/do-plumbing-clone.sh

@@ -24,5 +24,6 @@ do-plumbing-clone() {
 	gitArgs+=("$uri")
 	gitArgs+=("$BPM_PACKAGES_PATH/$package")
 
+	log.info "Cloning package '$package'"
 	git clone "${gitArgs[@]}"
 }

pkg/lib/commands/do-plumbing-deps.sh

@@ -24,6 +24,7 @@ do-plumbing-deps() {
 		IFS=':' read -ra deps <<< "$REPLY"
 	fi
 
+	log.info "Installing dependencies for '$package'"
 	for dep in "${deps[@]}"; do
 		do-install "$dep"
 	done

pkg/lib/commands/do-plumbing-link-bins.sh

@@ -2,9 +2,10 @@
 
 do-plumbing-link-bins() {
 	local package="$1"
-
 	ensure.nonZero 'package' "$package"
 
+	log.info "Linking bin files for '$package'"
+
 	local REMOVE_EXTENSION=
 	local -a bins=()
 
@@ -54,5 +55,4 @@ do-plumbing-link-bins() {
 		ln -sf "$BPM_PACKAGES_PATH/$package/$bin" "$BPM_INSTALL_BIN/$name"
 		chmod +x "$BPM_INSTALL_BIN/$name"
 	done
-
 }

pkg/lib/commands/do-plumbing-link-completions.sh

@@ -4,6 +4,8 @@ do-plumbing-link-completions() {
 	local package="$1"
 	ensure.nonZero 'package' "$package"
 
+	log.info "Linking completion files for '$package'"
+
 	local -a completions=()
 	local -a bash_completions=() zsh_completions=()
 

pkg/lib/commands/do-plumbing-link-man.sh

@@ -5,6 +5,8 @@ do-plumbing-link-man() {
 	local package="$1"
 	ensure.nonZero 'package' "$package"
 
+	log.info "Linking man files for '$package'"
+
 	local -a mans=()
 
 	local bpmTomlFile="$BPM_PACKAGES_PATH/$package/bpm.toml"

pkg/lib/commands/do-plumbing-unlink-bins.sh

@@ -4,6 +4,8 @@ do-plumbing-unlink-bins() {
 	local package="$1"
 	ensure.nonZero 'package' "$package"
 
+	log.info "Unlinking bin files for '$package'"
+
 	local -a bins=()
 	local REMOVE_EXTENSION=
 

pkg/lib/commands/do-plumbing-unlink-completions.sh

@@ -4,6 +4,8 @@ do-plumbing-unlink-completions() {
 	local package="$1"
 	ensure.nonZero 'package' "$package"
 
+	log.info "Unlinking completion files for '$package'"
+
 	local -a bash_completions=() zsh_completions=()
 
 	local packageShFile="$BPM_PACKAGES_PATH/$package/package.sh"

pkg/lib/commands/do-plumbing-unlink-man.sh

@@ -4,6 +4,8 @@ do-plumbing-unlink-man() {
 	local package="$1"
 	ensure.nonZero 'package' "$package"
 
+	log.info "Unlinking man files for '$package'"
+
 	local files=("$BPM_PACKAGES_PATH/$package"/man/*)
 	files=("${files[@]##*/}")
 

tests/do-plumbing-clone.bats

@@ -8,7 +8,7 @@ load 'util/init.sh'
 	run do-plumbing-clone https://site/username/package.git username/package version
 
 	assert_success
-	assert_output "git clone --recursive --depth=1 --branch version https://site/username/package.git $BPM_PACKAGES_PATH/username/package"
+	assert_line -n 1 "git clone --recursive --depth=1 --branch version https://site/username/package.git $BPM_PACKAGES_PATH/username/package"
 }
 
 @test "does nothing if package is already present" {
@@ -17,7 +17,7 @@ load 'util/init.sh'
 	run do-plumbing-clone https://github.com/username/package.git username/package
 
 	assert_failure
-	assert_output -e "Package 'username/package' is already present"
+	assert_line -n 0 -p "Package 'username/package' is already present"
 }
 
 @test "does nothing if package is already present (as erroneous file)" {
@@ -27,7 +27,7 @@ load 'util/init.sh'
 	run do-plumbing-clone https://github.com/username/package.git username/package
 
 	assert_failure
-	assert_output -e "Package 'username/package' is already present"
+	assert_line -n 0 -p "Package 'username/package' is already present"
 }
 
 @test "using a different site" {
@@ -36,7 +36,7 @@ load 'util/init.sh'
 	run do-plumbing-clone https://site/username/package.git username/package
 
 	assert_success
-	assert_output "git clone --recursive --depth=1 https://site/username/package.git $BPM_PACKAGES_PATH/username/package"
+	assert_line -n 1 "git clone --recursive --depth=1 https://site/username/package.git $BPM_PACKAGES_PATH/username/package"
 }
 
 
@@ -49,7 +49,7 @@ load 'util/init.sh'
 	run do-plumbing-clone https://github.com/username/package.git username/package
 
 	assert_success
-	assert_output "git clone --recursive https://github.com/username/package.git $BPM_PACKAGES_PATH/username/package"
+	assert_line -n 1 "git clone --recursive https://github.com/username/package.git $BPM_PACKAGES_PATH/username/package"
 }
 
 @test "setting BPM_FULL_CLONE to true, clones a package without depth option" {
@@ -59,7 +59,7 @@ load 'util/init.sh'
 	run do-plumbing-clone https://github.com/username/package.git username/package
 
 	assert_success
-	assert_output "git clone --recursive https://github.com/username/package.git $BPM_PACKAGES_PATH/username/package"
+	assert_line -n 1 "git clone --recursive https://github.com/username/package.git $BPM_PACKAGES_PATH/username/package"
 }
 
 # This is a difference in behavior compared to Basher. Setting
@@ -71,7 +71,7 @@ load 'util/init.sh'
 	run do-plumbing-clone https://github.com/username/package.git username/package
 
 	assert_success
-	assert_output "git clone --recursive https://github.com/username/package.git $BPM_PACKAGES_PATH/username/package"
+	assert_line -n 1 "git clone --recursive https://github.com/username/package.git $BPM_PACKAGES_PATH/username/package"
 }
 
 @test "using ssh protocol" {
@@ -80,5 +80,5 @@ load 'util/init.sh'
 	run do-plumbing-clone git@site:username/package.git username/package
 
 	assert_success
-	assert_output "git clone --recursive --depth=1 git@site:username/package.git $BPM_PACKAGES_PATH/username/package"
+	assert_line -n 1 "git clone --recursive --depth=1 git@site:username/package.git $BPM_PACKAGES_PATH/username/package"
 }