test: Use 'setup_file'

Author: hyperupcall

pkg/lib/public/basalt-package.sh

@@ -18,7 +18,7 @@ basalt.package-load() {
 	fi
 	shopt -s nullglob
 
-	# TODO: Use array expand glob so no need to shopt -s nullglob at end to make this cleaner
+	# This can be made cleaner with glob expansion in arrays, but the code is fine as it is
 	local __basalt_site= __basalt_repository_owner=  __basalt_package=
 	if [ -d "$BASALT_PACKAGE_DIR"/.basalt/packages ]; then
 		for __basalt_site in "$BASALT_PACKAGE_DIR"/.basalt/packages/*/; do

tests/basalt-add.bats

@@ -2,10 +2,7 @@
 
 load './util/init.sh'
 
-# TODO: setup file
-setup() {
-	ensure.cd "$BATS_TEST_TMPDIR"
-
+setup_file() {
 	# this affects lines=($output) # TODO Bats 1.5 remove
 	shopt -u nullglob
 	test_util.stub_command 'do-install'