fix: Show error if some commands are operating in 'local' or 'global'

mode. Closes #67

Author: hyperupcall

pkg/lib/commands/do-add.sh

@@ -32,14 +32,17 @@ do-add() {
 		esac
 	done
 
+	if [[ "$BPM_IS_LOCAL" == no && "$flag_all" == yes ]]; then
+		die "Cannot pass '--all' without a 'bpm.toml' file"
+	fi
+
 	if [ "$flag_all" = yes ]; then
 		local bpm_toml_file="$BPM_ROOT/bpm.toml"
 
 		if (( ${#pkgs[@]} > 0 )); then
 			die "No packages may be supplied when using '--all'"
 		fi
 
-		# TODO: this may be ran under 'global' mode?
 		if util.get_toml_array "$bpm_toml_file" 'dependencies'; then
 			log.info "Adding all dependencies"
 
@@ -88,7 +91,6 @@ do-actual-add() {
 	do-plumbing-link-completions "$site/$package"
 	do-plumbing-link-man "$site/$package"
 
-	# TODO: install for packages.sh
 	# Install transitive dependencies
 	local subDep="$BPM_PACKAGES_PATH/$site/$package"
 

pkg/lib/commands/do-plumbing-clone.sh

@@ -9,7 +9,6 @@ do-plumbing-clone() {
 	ensure.non_zero 'uri' "$uri"
 	ensure.non_zero 'id' "$id"
 
-	# TODO this is invalid in the test suite
 	if [ -e "$BPM_PACKAGES_PATH/$id" ]; then
 		die "Package '$id' is already present"
 	fi

pkg/lib/commands/do-upgrade.sh

@@ -24,10 +24,14 @@ do-upgrade() {
 		esac
 	done
 
-	if [[ $upgrade_bpm = yes && $flag_all = yes ]]; then
+	if [[ $upgrade_bpm == yes && "$flag_all" = yes ]]; then
 		die "Upgrading bpm and using '--all' are mutually exclusive behaviors"
 	fi
 
+	if [[ $upgrade_bpm == yes && "$BPM_IS_LOCAL" == yes ]]; then
+		die "Cannot upgrade bpm with a local 'bpm.toml' file"
+	fi
+
 	if [ "$upgrade_bpm" = 'yes' ]; then
 		if (( ${#pkgs[@]} > 0 )); then
 			die 'Packages cannot be upgraded at the same time as bpm'

pkg/lib/util/abstract-completions.sh

@@ -163,9 +163,8 @@ abstract.completions_do_action_zsh() {
 		fi
 
 		case "$action" in
-				link)
+		link)
 			if [ -L "$BPM_INSTALL_COMPLETIONS/zsh/compsys/$fileName" ]; then
-				# TODO: ?
 				log.error "Skipping '$fileName' since an existing symlink with the same name already exists"
 			else
 				mkdir -p "$BPM_INSTALL_COMPLETIONS/zsh/compsys"

tests/do-add.bats

@@ -28,7 +28,6 @@ load 'util/init.sh'
 	assert_line -n 0 -p  "Cannot install packages owned by username 'local' because that conflicts with linked packages"
 }
 
-# TODO: do for link
 @test "fails when input is an absolute path to a directory" {
 	local site='github.com'
 	local pkg='username/main'
@@ -289,7 +288,7 @@ load 'util/init.sh'
 @test "--all prints warning when no dependencies are specified in bpm.toml" {
 	touch 'bpm.toml'
 
-	run do-add --all
+	BPM_IS_LOCAL='yes' run do-add --all
 
 	assert_success
 	assert_line -p "No dependencies specified in 'dependencies' key"
@@ -299,8 +298,15 @@ load 'util/init.sh'
 @test "--all errors when a package is specified as argument" {
 	touch 'bpm.toml'
 
-	run do-add --all pkg
+	BPM_IS_LOCAL='yes' run do-add --all pkg
 
 	assert_failure
 	assert_line -p "No packages may be supplied when using '--all'"
 }
+
+@test "--all errors in global mode" {
+	run do-add --all
+
+	assert_failure
+	assert_line -p "Cannot pass '--all' without a 'bpm.toml' file"
+}

tests/do-plumbing-clone.bats

@@ -2,8 +2,6 @@
 
 load 'util/init.sh'
 
-# TODO: replace output checking with actual cloning using file://
-
 @test "installs a specific version" {
 	local site='github.com'
 	local pkg='username/package'
@@ -129,3 +127,10 @@ load 'util/init.sh'
 	assert_success
 	assert_line -n 1 "git clone --recursive --depth=1 --single-branch --branch a_branch https://github.com/username/package.git $BPM_PACKAGES_PATH/$site/username/package"
 }
+
+@test "--all errors in global mode" {
+	run do-add --all
+
+	assert_failure
+	assert_line -p "Cannot pass '--all' without a 'bpm.toml' file"
+}

tests/do-upgrade.bats

@@ -189,10 +189,19 @@ load 'util/init.sh'
 	assert_line -p "Upgrading bpm and using '--all' are mutually exclusive behaviors"
 }
 
+@test "fail if bpm is specified in local mode" {
+	touch 'bpm.toml'
+
+	BPM_IS_LOCAL='yes' run do-upgrade bpm
+
+	assert_failure
+	assert_line -p "Cannot upgrade bpm with a local 'bpm.toml' file"
+}
+
 @test "--all errors when a package is specified as argument" {
 	touch 'bpm.toml'
 
-	run do-remove --all pkg
+	run do-upgrade --all some/pkg
 
 	assert_failure
 	assert_line -p "No packages may be supplied when using '--all'"

tests/util/init.sh

@@ -17,6 +17,7 @@ export BPM_TEST_DIR="$BATS_TMPDIR/bpm"
 export BPM_CWD="$BPM_TEST_DIR/cwd"
 export BPM_ORIGIN_DIR="$BPM_TEST_DIR/origin"
 export BPM_MODE_TEST=
+export BPM_IS_LOCAL='no' # normal default is 'yes'
 
 # Stub common variables
 test_util.get_bpm_root