Skip to content

Commit 55118b3

Browse files
committed
ci: Remove Bash 4.2 from test matrix
The only "potentially" "supported" distribution with Bash 4.2 is CentOS. Since the patch release number is quite high, assume that most Bash 4.2 bugs we encounter (like the one causing CI to fail right now) has been fixed
1 parent c44dcc0 commit 55118b3

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
build-linux:
1111
strategy:
1212
matrix:
13-
bashver: ["4.2", "4.3", "4.4", "5.0", "latest"]
13+
bashver: ["4.3", "4.4", "5.0", "latest"]
1414

1515
runs-on: ubuntu-latest
1616

docs/support.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ macOS
3030
| Ubuntu 20.10 | 5.0 | July 2021 | ✔️
3131
| Ubuntu 21.04 | 5.1 | January 2022 | ✔️
3232
| CentOS 6 | 4.1.p2 | November 30th, 2020 | ❌
33-
| CentOS 7 | 4.2.p46 | June 30th, 2024 |✔️
33+
| CentOS 7 | 4.2.p46 | June 30th, 2024 | ✔️
3434
| CentOS 8 | 5.0.p11 | December 31, 2021 | ✔️
3535
| Debian 9 Oldstable | 4.4 | June 30, 2022 | ✔️
3636
| Debian 10 Stable | 5.0 | June, 2024 | ✔️

tests/do-plumbing-link-bins.bats

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ load 'util/init.sh'
3434
run do-plumbing-link-bins "$package"
3535

3636
assert_success
37-
assert [ "$(readlink $BPM_INSTALL_BIN/exec1)" = "$BPM_PACKAGES_PATH/$package/weird_dir/exec1" ]
38-
assert [ "$(readlink $BPM_INSTALL_BIN/exec2.sh)" = "$BPM_PACKAGES_PATH/$package/weird_dir/exec2.sh" ]
37+
assert [ "$(readlink "$BPM_INSTALL_BIN/exec1")" = "$BPM_PACKAGES_PATH/$package/weird_dir/exec1" ]
38+
assert [ "$(readlink "$BPM_INSTALL_BIN/exec2.sh")" = "$BPM_PACKAGES_PATH/$package/weird_dir/exec2.sh" ]
3939
}
4040

4141
@test "bpm.toml has presidence over package.sh" {

0 commit comments

Comments
 (0)