test: Remove changes to BPM_ROOT in tests initialization

Author: hyperupcall

pkg/lib/commands/do-add.sh

@@ -84,7 +84,7 @@ do-add() {
 		if [[ ! -d "$subDep" && -n "${BPM_MODE_TEST+x}" ]]; then
 			# During some tests, plumbing-* or Git commands may be stubbed,
 			# so the package may not actually be cloned
-			return
+			continue
 		fi
 
 		local oldWd="$PWD"

tests/do-init.bats

@@ -35,15 +35,17 @@ load './util/init.sh'
 
 	eval "$(do-init bash)"
 
-	command -v _bpm
+	assert command -v _bpm
 }
 
 @test "is fish compatible" {
 	if ! command -v fish &>/dev/null; then
 		skip "Command 'fish' not in PATH"
 	fi
 
-	HOME= XDG_DATA_HOME= XDG_CONFIG_HOME= run fish -Pc '. (bpm init fish | psub)'
+	HOME= XDG_DATA_HOME= XDG_STATE_HOME= XDG_CONFIG_HOME= run fish -Pc '. (bpm init fish | psub)'
+
+	assert_success
 }
 
 @test "is sh-compatible" {

tests/util/init.sh

@@ -16,7 +16,7 @@ export LANG="C"
 export LANGUAGE="C"
 export LC_ALL="C"
 export XDG_DATA_HOME=
-export PATH="$BPM_ROOT/pkg/bin:$PATH"
+export PATH="$BPM_ROOT/pkg/bin:$PATH" # TODO
 
 export PROGRAM_LIB_DIR="$BATS_TEST_DIRNAME/../pkg/lib"
 export BPM_ROOT="$BATS_TEST_DIRNAME/.."