feat: Allow specifying multiple directories at once to link

Author: hyperupcall

pkg/lib/commands/do-link.sh

@@ -1,40 +1,44 @@
 # shellcheck shell=bash
 
 do-link() {
+	if (( $# == 0 )); then
+		die "You must supply at least one directory"
+	fi
+
 	local install_deps='yes'
 
-	case $1 in
-		--no-deps)
-			install_deps='no'
-			shift
+	case "$1" in
+	--no-deps)
+		install_deps='no'
+		shift
 		;;
 	esac
 
-	local directory="$1"
-
-	if [ ! -d "$directory" ]; then
-		die "Directory '$directory' not found"
-	fi
-
-	directory="$(util.readlink "$directory")"
-
-	local namespace="bpm-local"
-	local repository="${directory##*/}"
-	local package="$namespace/$repository"
-
-	if [ -e "$BPM_PACKAGES_PATH/$package" ]; then
-		die "Package '$package' is already present"
-	fi
-
-	# TODO: local git clone
-	mkdir -p "$BPM_PACKAGES_PATH/$namespace"
-	ln -s "$directory" "$BPM_PACKAGES_PATH/$package"
-
-	log.info "Linking '$directory'"
-	if [ "$install_deps" = 'yes' ]; then
-		do-plumbing-add-deps "$package"
-	fi
-	do-plumbing-link-bins "$package"
-	do-plumbing-link-completions "$package"
-	do-plumbing-link-man "$package"
+	for directory; do
+		if [ ! -d "$directory" ]; then
+			die "Directory '$directory' not found"
+		fi
+
+		directory="$(util.readlink "$directory")"
+
+		local namespace="bpm-local"
+		local repository="${directory##*/}"
+		local package="$namespace/$repository"
+
+		if [ -e "$BPM_PACKAGES_PATH/$package" ]; then
+			die "Package '$package' is already present"
+		fi
+
+		# TODO: local git clone
+		mkdir -p "$BPM_PACKAGES_PATH/$namespace"
+		ln -s "$directory" "$BPM_PACKAGES_PATH/$package"
+
+		log.info "Linking '$directory'"
+		if [ "$install_deps" = 'yes' ]; then
+			do-plumbing-add-deps "$package"
+		fi
+		do-plumbing-link-bins "$package"
+		do-plumbing-link-completions "$package"
+		do-plumbing-link-man "$package"
+	done
 }

tests/do-link.bats

@@ -83,6 +83,30 @@ load 'util/init.sh'
 
 }
 
+@test "calls link-bins, link-completions, link-man and deps in order for multiple directories" {
+	test_util.mock_command do-plumbing-add-deps
+	test_util.mock_command do-plumbing-link-bins
+	test_util.mock_command do-plumbing-link-completions
+	test_util.mock_command do-plumbing-link-man
+
+	mkdir 'package2' 'package3'
+
+	run do-link 'package2' 'package3'
+
+	assert_success
+	assert_line -n 0 -e "Linking '/(.*)/bpm/cwd/package2'"
+	assert_line -n 1 "do-plumbing-add-deps bpm-local/package2"
+	assert_line -n 2 "do-plumbing-link-bins bpm-local/package2"
+	assert_line -n 3 "do-plumbing-link-completions bpm-local/package2"
+	assert_line -n 4 "do-plumbing-link-man bpm-local/package2"
+	assert_line -n 5 -e "Linking '/(.*)/bpm/cwd/package3'"
+	assert_line -n 6 "do-plumbing-add-deps bpm-local/package3"
+	assert_line -n 7 "do-plumbing-link-bins bpm-local/package3"
+	assert_line -n 8 "do-plumbing-link-completions bpm-local/package3"
+	assert_line -n 9 "do-plumbing-link-man bpm-local/package3"
+
+}
+
 @test "respects the --no-deps option in the correct order" {
 	test_util.mock_command do-plumbing-add-deps
 	test_util.mock_command do-plumbing-link-bins