fix: Using wrong positional argument for do-plumbing-clone

Author: hyperupcall

pkg/lib/commands/do-plumbing-clone.sh

@@ -4,7 +4,7 @@ do-plumbing-clone() {
 	local use_ssh="$1"
 	local site="$2"
 	local package="$3"
-	local ref="$5"
+	local ref="$4"
 
 	ensure.nonZero 'use_ssh' "$use_ssh"
 	ensure.nonZero 'site' "$site"
@@ -22,7 +22,7 @@ do-plumbing-clone() {
 	fi
 
 	if [ -n "$ref" ]; then
-		gitArgs+=(-b "$ref")
+		gitArgs+=(--branch "$ref")
 	fi
 
 	if [ "$use_ssh" = "true" ]; then

tests/do-plumbing-clone.bats

@@ -8,7 +8,7 @@ load 'util/init.sh'
 	run do-plumbing-clone false site username/package version
 
 	assert_success
-	assert_output "git clone --recursive --depth=1 -b version https://site/username/package.git $BPM_PACKAGES_PATH/username/package"
+	assert_output "git clone --recursive --depth=1 --branch version https://site/username/package.git $BPM_PACKAGES_PATH/username/package"
 }
 
 @test "does nothing if package is already present" {