From 313c3f9a9744d376357aefc9a31004bbb2a252f2 Mon Sep 17 00:00:00 2001 From: Markus Podar Date: Sat, 3 Feb 2024 21:12:13 +0100 Subject: [PATCH 1/3] Remove doctrine/dbal:^4 support Tests fail with: `PHP Fatal error: Declaration of Illuminate\Database\PDO\Concerns\ConnectsToDatabase::connect(array $params, $username = null, $password = null, array $driverOptions = []) must be compatible with Doctrine\DBAL\Driver::connect(array $params): Doctrine\DBAL\Driver\Connection in /home/runner/work/laravel-ide-helper/laravel-ide-helper/vendor/laravel/framework/src/Illuminate/Database/PDO/Concerns/ConnectsToDatabase.php on line 22` --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 22d94d811..ef72894c6 100644 --- a/composer.json +++ b/composer.json @@ -24,7 +24,7 @@ "ext-json": "*", "barryvdh/reflection-docblock": "^2.0.6", "composer/class-map-generator": "^1.0", - "doctrine/dbal": "^2.6 || ^3 || ^4", + "doctrine/dbal": "^2.6 || ^3", "illuminate/console": "^8 || ^9 || ^10", "illuminate/filesystem": "^8 || ^9 || ^10", "illuminate/support": "^8 || ^9 || ^10", From 7b9519162fcb080b88bb284a1d7eedf7ca61130b Mon Sep 17 00:00:00 2001 From: Markus Podar Date: Sun, 4 Feb 2024 17:58:42 +0100 Subject: [PATCH 2/3] gha: install with downgrading all dependencies --- .github/workflows/run-integration-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-integration-tests.yml b/.github/workflows/run-integration-tests.yml index 31bc718b0..84345c5dc 100644 --- a/.github/workflows/run-integration-tests.yml +++ b/.github/workflows/run-integration-tests.yml @@ -62,7 +62,7 @@ jobs: run: | cd sample sed -e 's|"type": "project",|&\n"repositories": [ { "type": "path", "url": "../src" } ],|' -i composer.json - composer require --dev "barryvdh/laravel-ide-helper:*" + composer require --dev "barryvdh/laravel-ide-helper:*" --with-all-dependencies - name: Execute generate run run: | From 0726720be5e52b19da017304afd35d6d4e01ce4c Mon Sep 17 00:00:00 2001 From: Markus Podar Date: Sun, 4 Feb 2024 18:03:50 +0100 Subject: [PATCH 3/3] Add note to readme --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 92f04fa50..7050d13d1 100644 --- a/README.md +++ b/README.md @@ -33,6 +33,10 @@ Require this package with composer using the following command: composer require --dev barryvdh/laravel-ide-helper ``` +> [!NOTE] +> If you encounter version conflicts with doctrine/dbal, please try: +> `composer require --dev barryvdh/laravel-ide-helper --with-all-dependencies` + This package makes use of [Laravels package auto-discovery mechanism](https://medium.com/@taylorotwell/package-auto-discovery-in-laravel-5-5-ea9e3ab20518), which means if you don't install dev dependencies in production, it also won't be loaded. If for some reason you want manually control this: