Skip to content

Commit e65d30b

Browse files
authored
Remove doctrine/dbal:^4 support (#1507)
* Remove doctrine/dbal:^4 support Tests fail with: `PHP Fatal error: Declaration of Illuminate\Database\PDO\Concerns\ConnectsToDatabase::connect(array $params, $username = null, $password = null, array $driverOptions = []) must be compatible with Doctrine\DBAL\Driver::connect(array $params): Doctrine\DBAL\Driver\Connection in /home/runner/work/laravel-ide-helper/laravel-ide-helper/vendor/laravel/framework/src/Illuminate/Database/PDO/Concerns/ConnectsToDatabase.php on line 22` * gha: install with downgrading all dependencies * Add note to readme
1 parent 416e0ab commit e65d30b

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

.github/workflows/run-integration-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
run: |
6363
cd sample
6464
sed -e 's|"type": "project",|&\n"repositories": [ { "type": "path", "url": "../src" } ],|' -i composer.json
65-
composer require --dev "barryvdh/laravel-ide-helper:*"
65+
composer require --dev "barryvdh/laravel-ide-helper:*" --with-all-dependencies
6666
6767
- name: Execute generate run
6868
run: |

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ Require this package with composer using the following command:
3333
composer require --dev barryvdh/laravel-ide-helper
3434
```
3535

36+
> [!NOTE]
37+
> If you encounter version conflicts with doctrine/dbal, please try:
38+
> `composer require --dev barryvdh/laravel-ide-helper --with-all-dependencies`
39+
3640
This package makes use of [Laravels package auto-discovery mechanism](https://medium.com/@taylorotwell/package-auto-discovery-in-laravel-5-5-ea9e3ab20518), which means if you don't install dev dependencies in production, it also won't be loaded.
3741

3842
If for some reason you want manually control this:

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"ext-json": "*",
2525
"barryvdh/reflection-docblock": "^2.0.6",
2626
"composer/class-map-generator": "^1.0",
27-
"doctrine/dbal": "^2.6 || ^3 || ^4",
27+
"doctrine/dbal": "^2.6 || ^3",
2828
"illuminate/console": "^8 || ^9 || ^10",
2929
"illuminate/filesystem": "^8 || ^9 || ^10",
3030
"illuminate/support": "^8 || ^9 || ^10",

0 commit comments

Comments
 (0)