Skip to content

Commit 327084e

Browse files
committed
Prevent accessors methods marked as private from being added
1 parent 0feb2f0 commit 327084e

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

src/Console/ModelsCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,7 @@ public function getPropertiesFromMethods($model)
573573
$methodReflections = $reflectionClass->getMethods();
574574
if ($methodReflections) {
575575
$methodReflections = array_filter($methodReflections, function ($methodReflection) {
576-
return !(
576+
return !$methodReflection->isPrivate() && !(
577577
$methodReflection->getDeclaringClass()->getName() === \Illuminate\Database\Eloquent\Model::class && (
578578
$methodReflection->getName() === 'setClassCastableAttribute' ||
579579
$methodReflection->getName() === 'setEnumCastableAttribute'

tests/Console/ModelsCommand/Getter/Models/Simple.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,4 +103,8 @@ public function getAttributeReturnsNullableCallableAttribute(): ?callable
103103
public function getAttributeReturnsVoidAttribute(): void
104104
{
105105
}
106+
107+
private function getInvalidAccessModifierAttribute()
108+
{
109+
}
106110
}

tests/Console/ModelsCommand/Getter/__snapshots__/Test__test__1.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,4 +133,8 @@ public function getAttributeReturnsNullableCallableAttribute(): ?callable
133133
public function getAttributeReturnsVoidAttribute(): void
134134
{
135135
}
136+
137+
private function getInvalidAccessModifierAttribute()
138+
{
139+
}
136140
}

0 commit comments

Comments
 (0)