Update finishSpanWithError API

Author: NipunaMadhushan

ballerina/natives.bal

@@ -77,7 +77,7 @@ public isolated function finishSpan(int spanId) returns error? = @java:Method {
 # + spanId - Id of span to finish
 # + errorMessage - Error message to be recorded in the span
 # + return - An error if an error occurred while finishing the span
-public isolated function finishSpanWithError(int spanId, string errorMessage) returns error? = @java:Method {
+public isolated function finishSpanWithError(int spanId, error 'error) returns error? = @java:Method {
     'class: "io.ballerina.stdlib.observe.nativeimpl.FinishSpan",
     name: "finishSpanWithError"
 } external;

native/src/main/java/io/ballerina/stdlib/observe/nativeimpl/FinishSpan.java

@@ -22,7 +22,7 @@
 import io.ballerina.runtime.api.Environment;
 import io.ballerina.runtime.api.creators.ErrorCreator;
 import io.ballerina.runtime.api.utils.StringUtils;
-import io.ballerina.runtime.api.values.BString;
+import io.ballerina.runtime.api.values.BError;
 
 /**
  * This function which implements the finishSpan method for observe.
@@ -42,9 +42,9 @@ public static Object finishSpan(Environment env, long spanId) {
                 "already finished")));
     }
 
-    public static Object finishSpanWithError(Environment env, long spanId, BString errorMessage) {
+    public static Object finishSpanWithError(Environment env, long spanId, BError error) {
         boolean isFinished = OpenTracerBallerinaWrapper.getInstance().finishSpanWithError(env, spanId,
-                errorMessage.getValue());
+                error);
 
         if (isFinished) {
             return null;

native/src/main/java/io/ballerina/stdlib/observe/nativeimpl/OpenTracerBallerinaWrapper.java

@@ -22,6 +22,7 @@
 import io.ballerina.runtime.api.Environment;
 import io.ballerina.runtime.api.creators.ErrorCreator;
 import io.ballerina.runtime.api.utils.StringUtils;
+import io.ballerina.runtime.api.values.BError;
 import io.ballerina.runtime.observability.ObserveUtils;
 import io.ballerina.runtime.observability.ObserverContext;
 import io.ballerina.runtime.observability.tracer.BSpan;
@@ -175,15 +176,15 @@ public boolean finishSpan(Environment env, long spanId) {
      * @param spanId id of the Span
      * @return boolean to indicate if span was finished
      */
-    public boolean finishSpanWithError(Environment env, long spanId, String errorValue) {
+    public boolean finishSpanWithError(Environment env, long spanId, BError error) {
 
         if (!enabled) {
             return false;
         }
         ObserverContext observerContext = observerContextMap.get(spanId);
         if (observerContext != null) {
             observerContext.addTag(TAG_KEY_ERROR, TAG_TRUE_VALUE);
-            observerContext.addProperty(PROPERTY_ERROR_VALUE, errorValue);
+            observerContext.addProperty(PROPERTY_ERROR_VALUE, error);
             if (observerContext.isSystemSpan()) {
                 ObserveUtils.setObserverContextToCurrentFrame(env, observerContext.getParent());
             }