Skip to content

Review "only unlock once per block" requirement #2

@jubeira

Description

@jubeira

Nodes can unlock the system either via the router entrypoint or via signatures in the before swap hook.

Do we really need to revert after the first one? If the system is unlocked, anyone can swap through the pools. Why should we revert when the nodes try to swap a second time?

See https://github.com/balancer/angstrom-router/blob/a6aeab77e387febce85169fb76ffdd25ca609864/contracts/AngstromRouter.sol#L198 for reference.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions