Simplify Dictionary::fromPairs

nyamsprod · nyamsprod · commit ddf83ff4e3e0 · 2022-03-31T12:13:38.000+02:00
diff --git a/src/Dictionary.php b/src/Dictionary.php
@@ -63,11 +63,11 @@ public static function fromAssociative(iterable $members = []): self
      */
     public static function fromPairs(Dictionary|iterable $pairs = []): self
     {
-        $instance = new self();
         if ($pairs instanceof Dictionary) {
-            $pairs = $pairs->toPairs();
+            return clone $pairs;
         }
 
+        $instance = new self();
         foreach ($pairs as [$key, $member]) {
             $instance->set($key, $member);
         }

Original file line number	Diff line number	Diff line change
`@@ -63,11 +63,11 @@ public static function fromAssociative(iterable $members = []): self`
`63`	`63`	`*/`
`64`	`64`	`public static function fromPairs(Dictionary\|iterable $pairs = []): self`
`65`	`65`	`{`
`66`		`- $instance = new self();`
`67`	`66`	`if ($pairs instanceof Dictionary) {`
`68`		`- $pairs = $pairs->toPairs();`
	`67`	`+ return clone $pairs;`
`69`	`68`	`}`
`70`	`69`
	`70`	`+ $instance = new self();`
`71`	`71`	`foreach ($pairs as [$key, $member]) {`
`72`	`72`	`$instance->set($key, $member);`
`73`	`73`	`}`