Improve InnerList::clear testing

Author: nyamsprod

CHANGELOG.md

@@ -6,9 +6,9 @@ All Notable changes to `bakame/http-strucured-fields` will be documented in this
 
 ### Added
 
-- The `MemberContainer` interface.
+- The `Container` interface.
 - The `ParameterAccess` interface.
-- The `InvaludArgument` exception.
+- The `InvalidArgument` exception.
 - `OrderedList`, `InnerList` now implements the `MemberList` interface.
 - `Parameters` and `Dictionnary` now implements the PHP `OrderedMap` interface.
 - `Token::value` is a readonly property.
@@ -17,10 +17,9 @@ All Notable changes to `bakame/http-strucured-fields` will be documented in this
 
 ### Fixed
 
-- **[BC Break]** `Item::value` readonly property is removed; use `Item::value()` method instead.
-- **[BC Break]** `Parameters::values` and `Parameters::value` methods also decode `ByteSequence` and `Token` classes.
-- **[BC Break]** `Parameters::values` methods no longer throw on invalid state; value is skipped from returned array.
-- **[BC Break]** `Parameters::value` methods no longer throw on invalid state; `null` value is returned instead.
+- **[BC Break]** `Parameters::values` and `Parameters::value` decode `ByteSequence` and `Token` classes.
+- **[BC Break]** `Parameters::values` no longer throw on invalid state; value is skipped from returned array.
+- **[BC Break]** `Parameters::value` no longer throw on invalid state; `null` value is returned instead.
 
 ### Deprecated
 

src/InnerListTest.php

@@ -22,10 +22,13 @@ public function it_can_be_instantiated_with_an_collection_of_item(): void
 
         self::assertSame($stringItem, $instance->get(0));
         self::assertTrue($instance->hasMembers());
-
+        self::assertTrue($instance->parameters->hasMembers());
         self::assertEquals($arrayParams, iterator_to_array($instance));
+
         $instance->clear();
+
         self::assertFalse($instance->hasMembers());
+        self::assertTrue($instance->parameters->hasMembers());
     }
 
     /** @test */

src/OrderedListTest.php

@@ -9,7 +9,7 @@
  */
 final class OrderedListTest extends StructuredFieldTest
 {
-    /** @var array|string[] */
+    /** @var array<string> */
     protected array $paths = [
         __DIR__.'/../vendor/httpwg/structured-field-tests/list.json',
         __DIR__.'/../vendor/httpwg/structured-field-tests/listlist.json',
@@ -60,7 +60,7 @@ public function it_can_add_or_remove_members(): void
     /** @test */
     public function it_can_unshift_insert_and_replace(): void
     {
-        $instance = OrderedList::fromList();
+        $instance = OrderedList::from();
         $instance->unshift(Item::from('42'));
         $instance->push(Item::from(42));
         $instance->insert(1, Item::from(42.0));
@@ -79,7 +79,7 @@ public function it_fails_to_replace_invalid_index(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        $container = OrderedList::fromList();
+        $container = OrderedList::from();
         $container->replace(0, Item::from(ByteSequence::fromDecoded('Hello World')));
     }
 
@@ -88,7 +88,7 @@ public function it_fails_to_insert_at_an_invalid_index(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        $container = OrderedList::fromList();
+        $container = OrderedList::from();
         $container->insert(3, Item::from(ByteSequence::fromDecoded('Hello World')));
     }
 
@@ -97,7 +97,7 @@ public function it_fails_to_return_an_member_with_invalid_index(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        $instance = OrderedList::fromList();
+        $instance = OrderedList::from();
         self::assertFalse($instance->has(3));
 
         $instance->get(3);
@@ -121,7 +121,7 @@ public function test_it_can_generate_the_same_value(): void
     /** @test */
     public function it_implements_the_array_access_interface(): void
     {
-        $sequence = OrderedList::fromList();
+        $sequence = OrderedList::from();
         $sequence[] = InnerList::from(42, 69);
 
         self::assertTrue(isset($sequence[0]));
@@ -142,7 +142,7 @@ public function it_fails_to_insert_unknown_index_via_the_array_access_interface(
     {
         $this->expectException(StructuredFieldError::class);
 
-        $sequence = OrderedList::fromList();
+        $sequence = OrderedList::from();
         $sequence[0] = Item::from(42.0);
     }
 
@@ -160,7 +160,7 @@ public function it_fails_http_conversion_with_invalid_parameters(): void
     {
         $this->expectException(StructuredFieldError::class);
 
-        $structuredField = OrderedList::fromList();
+        $structuredField = OrderedList::from();
         $structuredField[] = 42;
         $item = $structuredField[0];
         $item->parameters->append('forty-two', '42');

src/ParametersTest.php

@@ -11,7 +11,7 @@
  */
 final class ParametersTest extends StructuredFieldTest
 {
-    /** @var array|string[] */
+    /** @var array<string> */
     protected array $paths = [
         __DIR__.'/../vendor/httpwg/structured-field-tests/param-dict.json',
         __DIR__.'/../vendor/httpwg/structured-field-tests/param-list.json',