Improve Public API around Collection instantiation

nyamsprod · nyamsprod · commit 9c1e3ebfd196 · 2023-01-13T06:54:54.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,26 +7,23 @@ All Notable changes to `bakame/http-strucured-fields` will be documented in this
 ### Added
 
 - `ParameterAccess` interface updated with 3 new methods to ease parameter members modification.
-- Support for `Stringable` instance to `Item::from`, the instances will be converted to the string data type.
-- `Parameter::new` named constructor to create a new instance without any parameter.
-- `Dictionnary::new` named constructor to create a new instance without any parameter.
-- `InnerList::new` named constructor to create a new instance with members as variadic arguments.
-- `OrderedList::new` named constructor to create a new instance with members as variadic arguments.
+- Support for `Stringable` instance added to `Item::from`, the instances will be converted to the string data type.
+- `Parameter::create` named constructor to create a new instance without any parameter.
+- `Dictionnary::create` named constructor to create a new instance without any parameter.
 
 ### Fixed
 
 - **[BC Break]** `::fromAssociative`, `::fromList`, `::fromPairs` methods require iterable arguments without default value.
 - **[BC Break]** `Item::value` method returns the Item (returns value can be `float|int|string|bool|ByteSequence|Token`).
-- `InnerList::parameters` is no longer accessible as a public readonly property.
+- **[BC Break]** `InnerList::parameters` is no longer accessible as a public readonly property.
 
 ### Deprecated
 
 - None
 
 ### Removed
 
-- **[BC Break]** `InnerList::from` named constructor use `InnerList::new` method instead.
-- **[BC Break]** `OrderedList::from` named constructor use `OrderedList::new` method instead.
+- None
 
 ## [0.6.0] - 2022-11-12
 
diff --git a/docs/lists.md b/docs/lists.md
@@ -46,7 +46,7 @@ $innerList->push(Token::fromString('forty-two'));
 $innerList->remove(0, 2);
 echo $innerList->toHttpValue(); //returns '(42.0 forty-two);a'
 
-$orderedList = OrderedList::new(
+$orderedList = OrderedList::from(
     Item::from("42", ["foo" => "bar"]), 
     $innerList
 );
diff --git a/src/Dictionary.php b/src/Dictionary.php
@@ -28,7 +28,7 @@ private function __construct()
     /**
      * Returns a new instance.
      */
-    public static function new(): self
+    public static function create(): self
     {
         return new self();
     }
diff --git a/src/DictionaryTest.php b/src/DictionaryTest.php
@@ -91,7 +91,7 @@ public function it_can_add_or_remove_members(): void
     /** @test */
     public function it_fails_to_return_an_member_with_invalid_key(): void
     {
-        $instance = Dictionary::new();
+        $instance = Dictionary::create();
 
         self::assertFalse($instance->has('foobar'));
 
@@ -103,7 +103,7 @@ public function it_fails_to_return_an_member_with_invalid_key(): void
     /** @test */
     public function it_fails_to_return_an_member_with_invalid_index(): void
     {
-        $instance = Dictionary::new();
+        $instance = Dictionary::create();
 
         self::assertFalse($instance->hasPair(3));
 
@@ -123,7 +123,7 @@ public function it_fails_to_add_an_item_with_wrong_key(): void
     /** @test */
     public function it_can_prepend_a_new_member(): void
     {
-        $instance = Dictionary::new();
+        $instance = Dictionary::create();
         $instance->append('a', Item::from(false));
         $instance->prepend('b', Item::from(true));
 
@@ -133,7 +133,7 @@ public function it_can_prepend_a_new_member(): void
     /** @test */
     public function it_can_returns_the_container_member_keys(): void
     {
-        $instance = Dictionary::new();
+        $instance = Dictionary::create();
 
         self::assertSame([], $instance->keys());
 
@@ -227,13 +227,13 @@ public function it_fails_to_add_an_integer_via_array_access(): void
     {
         $this->expectException(StructuredFieldError::class);
 
-        Dictionary::new()[0] = 23; // @phpstan-ignore-line
+        Dictionary::create()[0] = 23; // @phpstan-ignore-line
     }
 
     /** @test */
     public function it_can_delete_a_member_via_array_access(): void
     {
-        $structuredField = Dictionary::new();
+        $structuredField = Dictionary::create();
         $structuredField['foo'] = 'bar';
 
         self::assertTrue($structuredField->hasMembers());
@@ -248,7 +248,7 @@ public function it_fails_to_fetch_an_value_using_an_integer(): void
     {
         $this->expectException(StructuredFieldError::class);
 
-        Dictionary::new()->get(0);
+        Dictionary::create()->get(0);
     }
 
     /** @test */
diff --git a/src/InnerList.php b/src/InnerList.php
@@ -27,7 +27,7 @@ private function __construct(private readonly Parameters $parameters)
     /**
      * Returns a new instance.
      */
-    public static function new(Item|ByteSequence|Token|Stringable|bool|int|float|string ...$members): self
+    public static function from(Item|ByteSequence|Token|Stringable|bool|int|float|string ...$members): self
     {
         return self::fromList($members);
     }
diff --git a/src/InnerListTest.php b/src/InnerListTest.php
@@ -65,7 +65,7 @@ public function it_can_add_or_remove_members(): void
     /** @test */
     public function it_can_unshift_insert_and_replace(): void
     {
-        $container = InnerList::new();
+        $container = InnerList::from();
         $container->unshift('42');
         $container->push(42);
         $container->insert(1, 42.0);
@@ -81,21 +81,21 @@ public function it_fails_to_replace_invalid_index(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        InnerList::new()->replace(0, ByteSequence::fromDecoded('Hello World'));
+        InnerList::from()->replace(0, ByteSequence::fromDecoded('Hello World'));
     }
 
     /** @test */
     public function it_fails_to_insert_at_an_invalid_index(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        InnerList::new()->insert(3, ByteSequence::fromDecoded('Hello World'));
+        InnerList::from()->insert(3, ByteSequence::fromDecoded('Hello World'));
     }
 
     /** @test */
     public function it_fails_to_return_an_member_with_invalid_index(): void
     {
-        $instance = InnerList::new();
+        $instance = InnerList::from();
 
         self::assertFalse($instance->has(3));
 
@@ -146,7 +146,7 @@ public function it_successfully_parse_a_http_field_with_optional_white_spaces_in
     /** @test */
     public function it_implements_the_array_access_interface(): void
     {
-        $sequence = InnerList::new();
+        $sequence = InnerList::from();
         $sequence[] = 42;
 
         self::assertTrue(isset($sequence[0]));
@@ -165,13 +165,13 @@ public function it_fails_to_insert_unknown_index_via_the_array_access_interface(
     {
         $this->expectException(StructuredFieldError::class);
 
-        InnerList::new()[0] = Item::from(42.0);
+        InnerList::from()[0] = Item::from(42.0);
     }
 
     /** @test */
     public function testArrayAccessThrowsInvalidIndex2(): void
     {
-        $sequence = InnerList::new();
+        $sequence = InnerList::from();
         unset($sequence[0]);
 
         self::assertCount(0, $sequence);
@@ -182,7 +182,7 @@ public function it_fails_to_fetch_an_value_using_an_integer(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        InnerList::new()->get('zero');
+        InnerList::from()->get('zero');
     }
 
     /** @test */
diff --git a/src/OrderedList.php b/src/OrderedList.php
@@ -31,7 +31,7 @@ private function __construct()
      *
      * @return static
      */
-    public static function new(InnerList|Item|ByteSequence|Token|Stringable|bool|int|float|string ...$members): self
+    public static function from(InnerList|Item|ByteSequence|Token|Stringable|bool|int|float|string ...$members): self
     {
         return self::fromList($members);
     }
@@ -65,7 +65,7 @@ private static function filterMember(StructuredField|ByteSequence|Token|Stringab
      */
     public static function fromHttpValue(Stringable|string $httpValue): self
     {
-        return self::new()
+        return self::from()
             ->push(...array_map(
                 fn ($value) => is_array($value) ? InnerList::fromList(...$value) : $value,
                 Parser::parseList($httpValue)
diff --git a/src/OrderedListTest.php b/src/OrderedListTest.php
@@ -61,7 +61,7 @@ public function it_can_add_or_remove_members(): void
     /** @test */
     public function it_can_unshift_insert_and_replace(): void
     {
-        $instance = OrderedList::new();
+        $instance = OrderedList::from();
         $instance->unshift(Item::from('42'));
         $instance->push(Item::from(42));
         $instance->insert(1, Item::from(42.0));
@@ -80,21 +80,21 @@ public function it_fails_to_replace_invalid_index(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        OrderedList::new()->replace(0, Item::from(ByteSequence::fromDecoded('Hello World')));
+        OrderedList::from()->replace(0, Item::from(ByteSequence::fromDecoded('Hello World')));
     }
 
     /** @test */
     public function it_fails_to_insert_at_an_invalid_index(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        OrderedList::new()->insert(3, Item::from(ByteSequence::fromDecoded('Hello World')));
+        OrderedList::from()->insert(3, Item::from(ByteSequence::fromDecoded('Hello World')));
     }
 
     /** @test */
     public function it_fails_to_return_an_member_with_invalid_index(): void
     {
-        $instance = OrderedList::new();
+        $instance = OrderedList::from();
 
         self::assertFalse($instance->has(3));
 
@@ -121,8 +121,8 @@ public function test_it_can_generate_the_same_value(): void
     /** @test */
     public function it_implements_the_array_access_interface(): void
     {
-        $sequence = OrderedList::new();
-        $sequence->push(InnerList::new(42, 69));
+        $sequence = OrderedList::from();
+        $sequence->push(InnerList::from(42, 69));
 
         self::assertTrue(isset($sequence[0]));
         self::assertInstanceOf(InnerList::class, $sequence[0]);
@@ -142,13 +142,13 @@ public function it_fails_to_insert_unknown_index_via_the_array_access_interface(
     {
         $this->expectException(StructuredFieldError::class);
 
-        OrderedList::new()[0] = Item::from(42.0);
+        OrderedList::from()[0] = Item::from(42.0);
     }
 
     /** @test */
     public function testArrayAccessThrowsInvalidIndex2(): void
     {
-        $sequence = OrderedList::new();
+        $sequence = OrderedList::from();
         unset($sequence[0]);
 
         self::assertCount(0, $sequence);
@@ -159,14 +159,14 @@ public function it_fails_to_fetch_an_value_using_an_integer(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        OrderedList::new()->get('zero');
+        OrderedList::from()->get('zero');
     }
 
     /** @test */
     public function it_can_access_the_item_value(): void
     {
         $token = Token::fromString('token');
-        $innerList = InnerList::new('test');
+        $innerList = InnerList::from('test');
         $input = ['foobar', 0, false, $token, $innerList];
         $structuredField = OrderedList::fromList($input);
 
diff --git a/src/Parameters.php b/src/Parameters.php
@@ -31,7 +31,7 @@ private function __construct()
     /**
      * Returns a new instance.
      */
-    public static function new(): self
+    public static function create(): self
     {
         return new self();
     }
diff --git a/src/ParametersTest.php b/src/ParametersTest.php
@@ -116,7 +116,7 @@ public function it_fails_to_return_an_member_with_invalid_key(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        $instance = Parameters::new();
+        $instance = Parameters::create();
         self::assertFalse($instance->has('foobar'));
 
         $instance->get('foobar');
@@ -125,7 +125,7 @@ public function it_fails_to_return_an_member_with_invalid_key(): void
     /** @test */
     public function it_fails_to_return_an_member_with_invalid_index(): void
     {
-        $instance = Parameters::new();
+        $instance = Parameters::create();
 
         self::assertFalse($instance->hasPair(3));
 
@@ -137,7 +137,7 @@ public function it_fails_to_return_an_member_with_invalid_index(): void
     /** @test */
     public function it_can_prepend_a_new_member(): void
     {
-        $instance = Parameters::new();
+        $instance = Parameters::create();
         $instance->append('a', Item::from(false));
         $instance->prepend('b', Item::from(true));
 
@@ -147,7 +147,7 @@ public function it_can_prepend_a_new_member(): void
     /** @test */
     public function it_can_returns_the_container_member_keys(): void
     {
-        $instance = Parameters::new();
+        $instance = Parameters::create();
 
         self::assertSame([], $instance->keys());
 
@@ -259,13 +259,13 @@ public function it_fails_to_add_an_integer_via_array_access(): void
     {
         $this->expectException(StructuredFieldError::class);
 
-        Parameters::new()[0] = 23; // @phpstan-ignore-line
+        Parameters::create()[0] = 23; // @phpstan-ignore-line
     }
 
     /** @test */
     public function it_can_delete_a_member_via_array_access(): void
     {
-        $structuredField = Parameters::new();
+        $structuredField = Parameters::create();
         $structuredField['foo'] = 'bar';
 
         self::assertTrue($structuredField->hasMembers());
@@ -280,14 +280,14 @@ public function it_fails_to_fetch_an_value_using_an_integer(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        Parameters::new()->get(0);
+        Parameters::create()->get(0);
     }
 
     /** @test */
     public function it_throws_if_the_structured_field_is_not_supported(): void
     {
         $this->expectException(InvalidArgument::class);
 
-        Parameters::fromPairs([['foo', InnerList::new(42)]]); // @phpstan-ignore-line
+        Parameters::fromPairs([['foo', InnerList::from(42)]]); // @phpstan-ignore-line
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ private function __construct()`
`28`	`28`	`/**`
`29`	`29`	`* Returns a new instance.`
`30`	`30`	`*/`
`31`		`- public static function new(): self`
	`31`	`+ public static function create(): self`
`32`	`32`	`{`
`33`	`33`	`return new self();`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ public function it_can_add_or_remove_members(): void`
`91`	`91`	`/** @test */`
`92`	`92`	`public function it_fails_to_return_an_member_with_invalid_key(): void`
`93`	`93`	`{`
`94`		`- $instance = Dictionary::new();`
	`94`	`+ $instance = Dictionary::create();`
`95`	`95`
`96`	`96`	`self::assertFalse($instance->has('foobar'));`
`97`	`97`
`@@ -103,7 +103,7 @@ public function it_fails_to_return_an_member_with_invalid_key(): void`
`103`	`103`	`/** @test */`
`104`	`104`	`public function it_fails_to_return_an_member_with_invalid_index(): void`
`105`	`105`	`{`
`106`		`- $instance = Dictionary::new();`
	`106`	`+ $instance = Dictionary::create();`
`107`	`107`
`108`	`108`	`self::assertFalse($instance->hasPair(3));`
`109`	`109`
`@@ -123,7 +123,7 @@ public function it_fails_to_add_an_item_with_wrong_key(): void`
`123`	`123`	`/** @test */`
`124`	`124`	`public function it_can_prepend_a_new_member(): void`
`125`	`125`	`{`
`126`		`- $instance = Dictionary::new();`
	`126`	`+ $instance = Dictionary::create();`
`127`	`127`	`$instance->append('a', Item::from(false));`
`128`	`128`	`$instance->prepend('b', Item::from(true));`
`129`	`129`
`@@ -133,7 +133,7 @@ public function it_can_prepend_a_new_member(): void`
`133`	`133`	`/** @test */`
`134`	`134`	`public function it_can_returns_the_container_member_keys(): void`
`135`	`135`	`{`
`136`		`- $instance = Dictionary::new();`
	`136`	`+ $instance = Dictionary::create();`
`137`	`137`
`138`	`138`	`self::assertSame([], $instance->keys());`
`139`	`139`
`@@ -227,13 +227,13 @@ public function it_fails_to_add_an_integer_via_array_access(): void`
`227`	`227`	`{`
`228`	`228`	`$this->expectException(StructuredFieldError::class);`
`229`	`229`
`230`		`- Dictionary::new()[0] = 23; // @phpstan-ignore-line`
	`230`	`+ Dictionary::create()[0] = 23; // @phpstan-ignore-line`
`231`	`231`	`}`
`232`	`232`
`233`	`233`	`/** @test */`
`234`	`234`	`public function it_can_delete_a_member_via_array_access(): void`
`235`	`235`	`{`
`236`		`- $structuredField = Dictionary::new();`
	`236`	`+ $structuredField = Dictionary::create();`
`237`	`237`	`$structuredField['foo'] = 'bar';`
`238`	`238`
`239`	`239`	`self::assertTrue($structuredField->hasMembers());`
`@@ -248,7 +248,7 @@ public function it_fails_to_fetch_an_value_using_an_integer(): void`
`248`	`248`	`{`
`249`	`249`	`$this->expectException(StructuredFieldError::class);`
`250`	`250`
`251`		`- Dictionary::new()->get(0);`
	`251`	`+ Dictionary::create()->get(0);`
`252`	`252`	`}`
`253`	`253`
`254`	`254`	`/** @test */`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ private function __construct(private readonly Parameters $parameters)`
`27`	`27`	`/**`
`28`	`28`	`* Returns a new instance.`
`29`	`29`	`*/`
`30`		`- public static function new(Item\|ByteSequence\|Token\|Stringable\|bool\|int\|float\|string ...$members): self`
	`30`	`+ public static function from(Item\|ByteSequence\|Token\|Stringable\|bool\|int\|float\|string ...$members): self`
`31`	`31`	`{`
`32`	`32`	`return self::fromList($members);`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ public function it_can_add_or_remove_members(): void`
`65`	`65`	`/** @test */`
`66`	`66`	`public function it_can_unshift_insert_and_replace(): void`
`67`	`67`	`{`
`68`		`- $container = InnerList::new();`
	`68`	`+ $container = InnerList::from();`
`69`	`69`	`$container->unshift('42');`
`70`	`70`	`$container->push(42);`
`71`	`71`	`$container->insert(1, 42.0);`
`@@ -81,21 +81,21 @@ public function it_fails_to_replace_invalid_index(): void`
`81`	`81`	`{`
`82`	`82`	`$this->expectException(InvalidOffset::class);`
`83`	`83`
`84`		`- InnerList::new()->replace(0, ByteSequence::fromDecoded('Hello World'));`
	`84`	`+ InnerList::from()->replace(0, ByteSequence::fromDecoded('Hello World'));`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`/** @test */`
`88`	`88`	`public function it_fails_to_insert_at_an_invalid_index(): void`
`89`	`89`	`{`
`90`	`90`	`$this->expectException(InvalidOffset::class);`
`91`	`91`
`92`		`- InnerList::new()->insert(3, ByteSequence::fromDecoded('Hello World'));`
	`92`	`+ InnerList::from()->insert(3, ByteSequence::fromDecoded('Hello World'));`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`/** @test */`
`96`	`96`	`public function it_fails_to_return_an_member_with_invalid_index(): void`
`97`	`97`	`{`
`98`		`- $instance = InnerList::new();`
	`98`	`+ $instance = InnerList::from();`
`99`	`99`
`100`	`100`	`self::assertFalse($instance->has(3));`
`101`	`101`
`@@ -146,7 +146,7 @@ public function it_successfully_parse_a_http_field_with_optional_white_spaces_in`
`146`	`146`	`/** @test */`
`147`	`147`	`public function it_implements_the_array_access_interface(): void`
`148`	`148`	`{`
`149`		`- $sequence = InnerList::new();`
	`149`	`+ $sequence = InnerList::from();`
`150`	`150`	`$sequence[] = 42;`
`151`	`151`
`152`	`152`	`self::assertTrue(isset($sequence[0]));`
`@@ -165,13 +165,13 @@ public function it_fails_to_insert_unknown_index_via_the_array_access_interface(`
`165`	`165`	`{`
`166`	`166`	`$this->expectException(StructuredFieldError::class);`
`167`	`167`
`168`		`- InnerList::new()[0] = Item::from(42.0);`
	`168`	`+ InnerList::from()[0] = Item::from(42.0);`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`/** @test */`
`172`	`172`	`public function testArrayAccessThrowsInvalidIndex2(): void`
`173`	`173`	`{`
`174`		`- $sequence = InnerList::new();`
	`174`	`+ $sequence = InnerList::from();`
`175`	`175`	`unset($sequence[0]);`
`176`	`176`
`177`	`177`	`self::assertCount(0, $sequence);`
`@@ -182,7 +182,7 @@ public function it_fails_to_fetch_an_value_using_an_integer(): void`
`182`	`182`	`{`
`183`	`183`	`$this->expectException(InvalidOffset::class);`
`184`	`184`
`185`		`- InnerList::new()->get('zero');`
	`185`	`+ InnerList::from()->get('zero');`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`/** @test */`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ private function __construct()`
`31`	`31`	`*`
`32`	`32`	`* @return static`
`33`	`33`	`*/`
`34`		`- public static function new(InnerList\|Item\|ByteSequence\|Token\|Stringable\|bool\|int\|float\|string ...$members): self`
	`34`	`+ public static function from(InnerList\|Item\|ByteSequence\|Token\|Stringable\|bool\|int\|float\|string ...$members): self`
`35`	`35`	`{`
`36`	`36`	`return self::fromList($members);`
`37`	`37`	`}`
`@@ -65,7 +65,7 @@ private static function filterMember(StructuredField\|ByteSequence\|Token\|Stringab`
`65`	`65`	`*/`
`66`	`66`	`public static function fromHttpValue(Stringable\|string $httpValue): self`
`67`	`67`	`{`
`68`		`- return self::new()`
	`68`	`+ return self::from()`
`69`	`69`	`->push(...array_map(`
`70`	`70`	`fn ($value) => is_array($value) ? InnerList::fromList(...$value) : $value,`
`71`	`71`	`Parser::parseList($httpValue)`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public function it_can_add_or_remove_members(): void`
`61`	`61`	`/** @test */`
`62`	`62`	`public function it_can_unshift_insert_and_replace(): void`
`63`	`63`	`{`
`64`		`- $instance = OrderedList::new();`
	`64`	`+ $instance = OrderedList::from();`
`65`	`65`	`$instance->unshift(Item::from('42'));`
`66`	`66`	`$instance->push(Item::from(42));`
`67`	`67`	`$instance->insert(1, Item::from(42.0));`
`@@ -80,21 +80,21 @@ public function it_fails_to_replace_invalid_index(): void`
`80`	`80`	`{`
`81`	`81`	`$this->expectException(InvalidOffset::class);`
`82`	`82`
`83`		`- OrderedList::new()->replace(0, Item::from(ByteSequence::fromDecoded('Hello World')));`
	`83`	`+ OrderedList::from()->replace(0, Item::from(ByteSequence::fromDecoded('Hello World')));`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`/** @test */`
`87`	`87`	`public function it_fails_to_insert_at_an_invalid_index(): void`
`88`	`88`	`{`
`89`	`89`	`$this->expectException(InvalidOffset::class);`
`90`	`90`
`91`		`- OrderedList::new()->insert(3, Item::from(ByteSequence::fromDecoded('Hello World')));`
	`91`	`+ OrderedList::from()->insert(3, Item::from(ByteSequence::fromDecoded('Hello World')));`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`/** @test */`
`95`	`95`	`public function it_fails_to_return_an_member_with_invalid_index(): void`
`96`	`96`	`{`
`97`		`- $instance = OrderedList::new();`
	`97`	`+ $instance = OrderedList::from();`
`98`	`98`
`99`	`99`	`self::assertFalse($instance->has(3));`
`100`	`100`
`@@ -121,8 +121,8 @@ public function test_it_can_generate_the_same_value(): void`
`121`	`121`	`/** @test */`
`122`	`122`	`public function it_implements_the_array_access_interface(): void`
`123`	`123`	`{`
`124`		`- $sequence = OrderedList::new();`
`125`		`- $sequence->push(InnerList::new(42, 69));`
	`124`	`+ $sequence = OrderedList::from();`
	`125`	`+ $sequence->push(InnerList::from(42, 69));`
`126`	`126`
`127`	`127`	`self::assertTrue(isset($sequence[0]));`
`128`	`128`	`self::assertInstanceOf(InnerList::class, $sequence[0]);`
`@@ -142,13 +142,13 @@ public function it_fails_to_insert_unknown_index_via_the_array_access_interface(`
`142`	`142`	`{`
`143`	`143`	`$this->expectException(StructuredFieldError::class);`
`144`	`144`
`145`		`- OrderedList::new()[0] = Item::from(42.0);`
	`145`	`+ OrderedList::from()[0] = Item::from(42.0);`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`/** @test */`
`149`	`149`	`public function testArrayAccessThrowsInvalidIndex2(): void`
`150`	`150`	`{`
`151`		`- $sequence = OrderedList::new();`
	`151`	`+ $sequence = OrderedList::from();`
`152`	`152`	`unset($sequence[0]);`
`153`	`153`
`154`	`154`	`self::assertCount(0, $sequence);`
`@@ -159,14 +159,14 @@ public function it_fails_to_fetch_an_value_using_an_integer(): void`
`159`	`159`	`{`
`160`	`160`	`$this->expectException(InvalidOffset::class);`
`161`	`161`
`162`		`- OrderedList::new()->get('zero');`
	`162`	`+ OrderedList::from()->get('zero');`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`/** @test */`
`166`	`166`	`public function it_can_access_the_item_value(): void`
`167`	`167`	`{`
`168`	`168`	`$token = Token::fromString('token');`
`169`		`- $innerList = InnerList::new('test');`
	`169`	`+ $innerList = InnerList::from('test');`
`170`	`170`	`$input = ['foobar', 0, false, $token, $innerList];`
`171`	`171`	`$structuredField = OrderedList::fromList($input);`
`172`	`172`
Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ public function it_fails_to_return_an_member_with_invalid_key(): void`
`116`	`116`	`{`
`117`	`117`	`$this->expectException(InvalidOffset::class);`
`118`	`118`
`119`		`- $instance = Parameters::new();`
	`119`	`+ $instance = Parameters::create();`
`120`	`120`	`self::assertFalse($instance->has('foobar'));`
`121`	`121`
`122`	`122`	`$instance->get('foobar');`
`@@ -125,7 +125,7 @@ public function it_fails_to_return_an_member_with_invalid_key(): void`
`125`	`125`	`/** @test */`
`126`	`126`	`public function it_fails_to_return_an_member_with_invalid_index(): void`
`127`	`127`	`{`
`128`		`- $instance = Parameters::new();`
	`128`	`+ $instance = Parameters::create();`
`129`	`129`
`130`	`130`	`self::assertFalse($instance->hasPair(3));`
`131`	`131`
`@@ -137,7 +137,7 @@ public function it_fails_to_return_an_member_with_invalid_index(): void`
`137`	`137`	`/** @test */`
`138`	`138`	`public function it_can_prepend_a_new_member(): void`
`139`	`139`	`{`
`140`		`- $instance = Parameters::new();`
	`140`	`+ $instance = Parameters::create();`
`141`	`141`	`$instance->append('a', Item::from(false));`
`142`	`142`	`$instance->prepend('b', Item::from(true));`
`143`	`143`
`@@ -147,7 +147,7 @@ public function it_can_prepend_a_new_member(): void`
`147`	`147`	`/** @test */`
`148`	`148`	`public function it_can_returns_the_container_member_keys(): void`
`149`	`149`	`{`
`150`		`- $instance = Parameters::new();`
	`150`	`+ $instance = Parameters::create();`
`151`	`151`
`152`	`152`	`self::assertSame([], $instance->keys());`
`153`	`153`
`@@ -259,13 +259,13 @@ public function it_fails_to_add_an_integer_via_array_access(): void`
`259`	`259`	`{`
`260`	`260`	`$this->expectException(StructuredFieldError::class);`
`261`	`261`
`262`		`- Parameters::new()[0] = 23; // @phpstan-ignore-line`
	`262`	`+ Parameters::create()[0] = 23; // @phpstan-ignore-line`
`263`	`263`	`}`
`264`	`264`
`265`	`265`	`/** @test */`
`266`	`266`	`public function it_can_delete_a_member_via_array_access(): void`
`267`	`267`	`{`
`268`		`- $structuredField = Parameters::new();`
	`268`	`+ $structuredField = Parameters::create();`
`269`	`269`	`$structuredField['foo'] = 'bar';`
`270`	`270`
`271`	`271`	`self::assertTrue($structuredField->hasMembers());`
`@@ -280,14 +280,14 @@ public function it_fails_to_fetch_an_value_using_an_integer(): void`
`280`	`280`	`{`
`281`	`281`	`$this->expectException(InvalidOffset::class);`
`282`	`282`
`283`		`- Parameters::new()->get(0);`
	`283`	`+ Parameters::create()->get(0);`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`/** @test */`
`287`	`287`	`public function it_throws_if_the_structured_field_is_not_supported(): void`
`288`	`288`	`{`
`289`	`289`	`$this->expectException(InvalidArgument::class);`
`290`	`290`
`291`		`- Parameters::fromPairs([['foo', InnerList::new(42)]]); // @phpstan-ignore-line`
	`291`	`+ Parameters::fromPairs([['foo', InnerList::from(42)]]); // @phpstan-ignore-line`
`292`	`292`	`}`
`293`	`293`	`}`